<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<blockquote dir="auto">
<blockquote>
<p>Nevertheless, in the general change, are you confident with this version that other uses do not rely on the old behavior?
How confident can you be ? If someone relies on undocumented side-effects of a function, then ¯\<em>(ツ)</em>/¯.</p>
</blockquote>
</blockquote>
<p dir="auto">I'd say that the function itself is the documentation for internal APIs, so I see it as changing a "documented" behavior. If there is code which relied on the behavior of always initializing the output, we may be adding new memory safety issues.</p>
<p dir="auto">I'd need your help to understand the balance between the risk of introducing a new issue vs the value of the change. Is your objection on the behavior of the function the fact that a <code>set()</code> function should not modify its output on failure, would a rename or explicit documentation about its behavior address it?</p>
<p dir="auto">Nevertheless, I find all the other changes in this patch set, as very useful.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_175214754">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/0473c5641242dc75d61f4213182a1e59/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_175214754"}}</script>
</p>
</div>
</body>
</html>