<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0; margin: 0 auto;">
<tbody>
<tr>
<td style="font-family: 'Helvetica Neue',Helvetica,Arial,sans-serif; overflow: hidden;" align="left" bgcolor="#ffffff">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0;">
<tbody>
<tr>
<td style="color: #333333; border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid; font-size: 15px; font-weight: bold; line-height: 1.4; padding: 20px 0;">
Merge request
<a href="https://gitlab.com/gnutls/gnutls/merge_requests/1010">!1010</a>
was reviewed by
<a href="https://gitlab.com/lumag">Dmitry Eremin-Solenikov</a>
</td>
</tr>
<tr>
<td style="overflow: hidden; font-size: 14px; line-height: 1.4; display: grid;">
<p style="color: #777777;">
<a href="https://gitlab.com/lumag">Dmitry Eremin-Solenikov</a>
started a new discussion
on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1010#note_175774785">src/Makefile.am</a>:
</p>
<table>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="275" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="281" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
281
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC281" class="line" lang="make"> <span class="nv" style="color: #008080;">b</span><span class="o" style="font-weight: 600;">=</span><span class="sb" style="color: #d14;">`</span><span class="nb" style="color: #0086b3;">echo</span> <span class="nv" style="color: #008080;">$@</span> | <span class="nb" style="color: #0086b3;">sed</span> <span class="s1" style="color: #d14;">'s/.stamp$$//'</span><span class="sb" style="color: #d14;">`</span><span class="p">;</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="275" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="282" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
282
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC282" class="line" lang="make"> <span class="k" style="font-weight: 600;">if</span> <span class="o" style="font-weight: 600;">!</span> <span class="nb" style="color: #0086b3;">test</span> <span class="nt" style="color: #000080;">-f</span> <span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>srcdir<span class="o" style="font-weight: 600;">}</span><span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>b<span class="o" style="font-weight: 600;">}</span>.c.bak<span class="p">;</span><span class="k" style="font-weight: 600;">then</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="275" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="283" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
283
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC283" class="line" lang="make"> <span class="nb" style="color: #0086b3;">echo</span> <span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>srcdir<span class="o" style="font-weight: 600;">}</span><span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>b<span class="o" style="font-weight: 600;">}</span>.c.bak<span class="p">;</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">This message can be less cryptic, explicitly mentioning that <code>.bak</code> is missing, thus calling autogen despite <code>--enable-local-libopts</code>.</p>
</div>
<p style="color: #777777;">
<a href="https://gitlab.com/lumag">Dmitry Eremin-Solenikov</a>
started a new discussion
on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1010#note_175774789">src/Makefile.am</a>:
</p>
<table>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="275" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="282" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
282
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC282" class="line" lang="make"> <span class="k" style="font-weight: 600;">if</span> <span class="o" style="font-weight: 600;">!</span> <span class="nb" style="color: #0086b3;">test</span> <span class="nt" style="color: #000080;">-f</span> <span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>srcdir<span class="o" style="font-weight: 600;">}</span><span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>b<span class="o" style="font-weight: 600;">}</span>.c.bak<span class="p">;</span><span class="k" style="font-weight: 600;">then</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="275" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="283" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
283
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC283" class="line" lang="make"> <span class="nb" style="color: #0086b3;">echo</span> <span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>srcdir<span class="o" style="font-weight: 600;">}</span><span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>b<span class="o" style="font-weight: 600;">}</span>.c.bak<span class="p">;</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="275" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="284" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
284
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC284" class="line" lang="make"> <span class="nv" style="color: #008080;">$(AUTOGEN)</span> <span class="nv" style="color: #008080;">$<</span><span class="p">;</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto"><code>$(AM_V_GEN) $(AUTOGEN) $<</code> ?</p>
</div>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1010">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/e5437fa88992d5c6ea840722ec1594a7/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1010"}}</script>
</p>
</div>
</body>
</html>