<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<blockquote dir="auto">
<p>I now realize it's not what you had in mind for <a href="https://gitlab.com/gnutls/gnutls/issues/684" data-original="#684" data-link="false" data-link-reference="false" data-project="179611" data-issue="17629410" data-reference-type="issue" data-container="body" data-placement="bottom" title="Eliminate alloca() use in the guile bindings" class="gfm gfm-issue has-tooltip">#684</a>, but I think it's an improvement nonetheless.</p>
</blockquote>
<p dir="auto">It's definitely an improvement !</p>
<p dir="auto">Please also realize that removing alloca() is not about portability regarding <a href="https://gitlab.com/gnutls/gnutls/issues/684" data-original="#684" data-link="false" data-link-reference="false" data-project="179611" data-issue="17629410" data-reference-type="issue" data-container="body" data-placement="bottom" title="Eliminate alloca() use in the guile bindings" class="gfm gfm-issue has-tooltip">#684</a>. It's about security concerns <em>in general</em>. The touched code might be perfectly save - but the goal is to have an automated check via CI that errors out when someone introduces uses of alloca() (potentially unsafe). To make that as simple-as-possible (no list of exceptions), we would like to get rid of alloca() everywhere. It's like the use of strncpy() - you can use it safely, but it's easy to overlook misuses - so better not use it.</p>
<p dir="auto">Could you please remove the 'Closes <a href="https://gitlab.com/gnutls/gnutls/issues/684" data-original="#684" data-link="false" data-link-reference="false" data-project="179611" data-issue="17629410" data-reference-type="issue" data-container="body" data-placement="bottom" title="Eliminate alloca() use in the guile bindings" class="gfm gfm-issue has-tooltip">#684</a>' from the commit message (and just push --force to update the MR) !? Then I can approve/merge :-)</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1022#note_178965591">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/36453d822ca25ffb7a44c30d92d4b689/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1022#note_178965591"}}</script>
</p>
</div>
</body>
</html>