<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<p style="color: #777777;">

<a href="https://gitlab.com/nmav">Nikos Mavrogiannopoulos</a>

commented on a

<a href="https://gitlab.com/gnutls/gnutls/merge_requests/1036#note_186083926">discussion</a>:

</p>

<div style="">

<p dir="auto">Interesting. There are <a href="https://codesearch.debian.net/search?q=gnutls_hmac_fast&perpkg=1" rel="nofollow noreferrer noopener" target="_blank">few users of this api</a>, and it seems they could potentially use the new variant if they use the new algorithm. I'd say it is nice to have.</p>

<p dir="auto">About this MR, I think we should test that a call to <code>gnutls_hmac_fast()</code> fails with a known error (probably in <code>tests/gnutls_hmac_fast.c</code>), so that we avoid a future regression, or an accidental crash.</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1036#note_186083926">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/05599e5ff5f326a10718a1cb8d5f58b1/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1036#note_186083926"}}</script>

</p>

</div>

</body>

</html>