<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0; margin: 0 auto;">
<tbody>
<tr>
<td style="font-family: 'Helvetica Neue',Helvetica,Arial,sans-serif; overflow: hidden;" align="left" bgcolor="#ffffff">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0;">
<tbody>
<tr>
<td style="color: #333333; border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid; font-size: 15px; font-weight: bold; line-height: 1.4; padding: 20px 0;">
Merge request
<a href="https://gitlab.com/gnutls/gnutls/merge_requests/1053">!1053</a>
was reviewed by
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
</td>
</tr>
<tr>
<td style="overflow: hidden; font-size: 14px; line-height: 1.4; display: grid;">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1053#note_199847813">src/Makefile.am</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="276" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
276
</td>
<td class="diff-line-num new_line" data-linenumber="276" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
276
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC276" class="line" lang="make"><span class="c" style="color: #998; font-style: italic;"># case --enable-local-libopts: We do not call AUTOGEN unless the .bak files are missing</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="277" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
277
</td>
<td class="diff-line-num new_line" data-linenumber="277" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
277
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC277" class="line" lang="make"><span class="nl">.def.stamp</span><span class="o" style="font-weight: 600;">:</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="278" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
278
</td>
<td class="diff-line-num new_line" data-linenumber="278" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
278
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC278" class="line" lang="make"> <span class="p">@</span><span class="nv" style="color: #008080;">b</span><span class="o" style="font-weight: 600;">=</span><span class="sb" style="color: #d14;">`</span><span class="nb" style="color: #0086b3;">echo</span> <span class="nv" style="color: #008080;">$@</span> | <span class="nb" style="color: #0086b3;">sed</span> <span class="s1" style="color: #d14;">'s/.stamp$$//'</span><span class="sb" style="color: #d14;">`</span><span class="p">;</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">I would add <code>$(AM_V_GEN)</code> here, instead of inside the <code>if</code>, so <code>GEN foo.def</code> is always printed upon make.</p>
</div>
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1053#note_199847814">src/Makefile.am</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="278" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
278
</td>
<td class="diff-line-num new_line" data-linenumber="278" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
278
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC278" class="line" lang="make"> <span class="p">@</span><span class="nv" style="color: #008080;">b</span><span class="o" style="font-weight: 600;">=</span><span class="sb" style="color: #d14;">`</span><span class="nb" style="color: #0086b3;">echo</span> <span class="nv" style="color: #008080;">$@</span> | <span class="nb" style="color: #0086b3;">sed</span> <span class="s1" style="color: #d14;">'s/.stamp$$//'</span><span class="sb" style="color: #d14;">`</span><span class="p">;</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="279" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
279
</td>
<td class="diff-line-num new_line old" data-linenumber="279" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC279" class="line" lang="make"> <span class="k" style="font-weight: 600;">if</span> <span class="o" style="font-weight: 600;">!</span> <span class="nb" style="color: #0086b3;">test</span> <span class="nt" style="color: #000080;">-f</span> <span class="nv" style="color: #008080;">$<span class="idiff left">$</span></span><span class="o" style="font-weight: 600;"><span class="idiff">{</span></span><span class="idiff">srcdir</span><span class="o" style="font-weight: 600;"><span class="idiff right">}</span></span><span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>b<span class="o" style="font-weight: 600;">}</span>.c.bak<span class="p">;</span><span class="k" style="font-weight: 600;">then</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="280" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="279" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
279
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC279" class="line" lang="make"> <span class="k" style="font-weight: 600;">if</span> <span class="o" style="font-weight: 600;">!</span> <span class="nb" style="color: #0086b3;">test</span> <span class="nt" style="color: #000080;">-f</span> <span class="nv" style="color: #008080;">$<span class="idiff left">(srcdir)</span></span><span class="idiff right">/</span><span class="nv" style="color: #008080;">$$</span><span class="o" style="font-weight: 600;">{</span>b<span class="o" style="font-weight: 600;">}</span>.c.bak<span class="p">;</span><span class="k" style="font-weight: 600;">then</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">The original rule (still there below line 290) came from:
<a href="https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#Installation-Directory-Variables" rel="nofollow noreferrer noopener" target="_blank">https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#Installation-Directory-Variables</a></p>
<p dir="auto">That said, the use of the shell variable <code>$srcdir</code> here was a bit redundant as automake always sets <code>$(srcdir)</code>.</p>
</div>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1053">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/5d399b96dfba32ed93fc8f4ac1744ffd/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1053"}}</script>
</p>
</div>
</body>
</html>