<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/ametzler">Andreas Metzler</a>
commented:
</p>
<div style="">
<p dir="auto">This would work. It uses GNU-make idioms, is this a problem?</p>
<pre class="code highlight js-syntax-highlight diff" lang="diff" v-pre="true"><code><span id="LC1" class="line" lang="diff"><span class="gh">diff --git a/cfg.mk b/cfg.mk</span></span>
<span id="LC2" class="line" lang="diff"><span class="gh">index ff79dbf2ed..dfa9857418 100644</span></span>
<span id="LC3" class="line" lang="diff"><span class="gd">--- a/cfg.mk</span></span>
<span id="LC4" class="line" lang="diff"><span class="gi">+++ b/cfg.mk</span></span>
<span id="LC5" class="line" lang="diff"><span class="p">@@ -143,6 +143,8 @@</span> ASM_SOURCES_XXX := \</span>
<span id="LC6" class="line" lang="diff"> lib/accelerated/x86/XXX/aes-ssse3-x86.s \</span>
<span id="LC7" class="line" lang="diff"> lib/accelerated/x86/XXX/aes-ssse3-x86_64.s</span>
<span id="LC8" class="line" lang="diff"> </span>
<span id="LC9" class="line" lang="diff"><span class="gi">+PL_NEEDS_FPIC := aesni-x86.s</span></span>
<span id="LC10" class="line" lang="diff"><span class="gi">+</span></span>
<span id="LC11" class="line" lang="diff"> ASM_SOURCES_ELF := $(subst XXX,elf,$(ASM_SOURCES_XXX))</span>
<span id="LC12" class="line" lang="diff"> ASM_SOURCES_COFF := $(subst XXX,coff,$(ASM_SOURCES_XXX))</span>
<span id="LC13" class="line" lang="diff"> ASM_SOURCES_MACOSX := $(subst XXX,macosx,$(ASM_SOURCES_XXX))</span>
<span id="LC14" class="line" lang="diff"><span class="p">@@ -193,7 +195,9 @@</span> lib/accelerated/x86/files.mk: $(ASM_SOURCES_ELF)</span>
<span id="LC15" class="line" lang="diff"> </span>
<span id="LC16" class="line" lang="diff"> # Appro's code</span>
<span id="LC17" class="line" lang="diff"> lib/accelerated/x86/elf/%.s: devel/perlasm/%.pl .submodule.stamp </span>
<span id="LC18" class="line" lang="diff"><span class="gd">- CC=gcc perl $< elf $@.tmp</span></span>
<span id="LC19" class="line" lang="diff"><span class="gi">+ CC=gcc perl $< elf \</span></span>
<span id="LC20" class="line" lang="diff"><span class="gi">+ $(if $(findstring $(@F),$(PL_NEEDS_FPIC)),-fPIC) \</span></span>
<span id="LC21" class="line" lang="diff"><span class="gi">+ $@.tmp</span></span>
<span id="LC22" class="line" lang="diff"> cat $<.license $@.tmp > $@ && rm -f $@.tmp</span>
<span id="LC23" class="line" lang="diff"> echo "" >> $@</span>
<span id="LC24" class="line" lang="diff"> echo ".section .note.GNU-stack,\"\",%progbits" >> $@</span></code></pre>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/818#note_203669643">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/dff2a2bbdf66632b3b83842cefef2207/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/818#note_203669643"}}</script>
</p>
</div>
</body>
</html>