<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>



<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">

<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0; margin: 0 auto;">
<tbody>
<tr>
<td style="font-family: 'Helvetica Neue',Helvetica,Arial,sans-serif; overflow: hidden;" align="left" bgcolor="#ffffff">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0;">
<tbody>
<tr>
<td style="color: #333333; border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid; font-size: 15px; font-weight: bold; line-height: 1.4; padding: 20px 0;">
Merge request
<a href="https://gitlab.com/gnutls/gnutls/merge_requests/1054">!1054</a>
was reviewed by
<a href="https://gitlab.com/tomato42">Hubert Kario (@mention me if you need reply)</a>
</td>
</tr>
<tr>
<td style="overflow: hidden; font-size: 14px; line-height: 1.4; display: grid;">
<p style="color: #777777;">
<a href="https://gitlab.com/tomato42">Hubert Kario (@mention me if you need reply)</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1054#note_213085855">tests/suite/testcompat-oldgnutls.sh</a>:
</p>
<table>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="1" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
 
</td>
<td class="diff-line-num new new_line" data-linenumber="121" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
121
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC121" class="line" lang="shell">        <span class="nb" style="color: #0086b3;">echo</span> <span class="o" style="font-weight: 600;">>></span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">TMPFILE</span><span class="k" style="font-weight: 600;">}</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="1" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
 
</td>
<td class="diff-line-num new new_line" data-linenumber="122" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
122
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC122" class="line" lang="shell">        <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">VALGRIND</span><span class="k" style="font-weight: 600;">}</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">CLI</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: #000080;">-d</span> 6 <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">DEBUG</span><span class="k" style="font-weight: 600;">}</span> <span class="nt" style="color: #000080;">-p</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">PORT</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> 127.0.0.1 <span class="nt" style="color: #000080;">--priority</span> <span class="s2" style="color: #d14;">"NONE:+AES-128-CBC:+SIGN-ALL:+COMP-NULL:+MAC-ALL:+VERS-TLS1.2:+RSA</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">ADD</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: #000080;">--insecure</span> <span class="nt" style="color: #000080;">--x509certfile</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">CLI_CERT</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: #000080;">--x509keyfile</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">CLI_KEY</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> <<span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">TMPFILE</span><span class="k" style="font-weight: 600;">}</span> <span class="o" style="font-weight: 600;">></span>/dev/null <span class="o" style="font-weight: 600;">||</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="1" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
 
</td>
<td class="diff-line-num new new_line" data-linenumber="123" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
123
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC123" class="line" lang="shell">                fail <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: #008080;">PID</span><span class="k" style="font-weight: 600;">}</span> <span class="s2" style="color: #d14;">"Failed"</span></span>
</pre>
</td>
</tr>

</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">wouldn't be a good idea to test with cipher that uses SHA258 or SHA384 HMAC?</p>
</div>

</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>

</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">

<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1054">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/4d6c999a969d7e032f22df052be57558/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1054"}}</script>


</p>
</div>
</body>
</html>