<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/issues/826#note_222343065">discussion</a>:
</p>
<div style="">
<blockquote dir="auto">
<p>Btw, did you get a chance to review the code?</p>
</blockquote>
<p dir="auto">Yes.</p>
<blockquote dir="auto">
<p>Looks good enough?</p>
</blockquote>
<p dir="auto">Sorry, I'm afraid not. I expect at least a test case that tells what you are trying to achieve (and I don't think the current code does anything meaningful: for example, <code>gnutls_quic_secret_hook_exchange</code> would only work after the handshake is complete, which is useless in QUIC).</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/826#note_222343065">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/241ac6370e07d3f4c8c8313495344719/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/826#note_222343065"}}</script>
</p>
</div>
</body>
</html>