<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/juaristi">Ander Juaristi</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/merge_requests/917#note_227571269">discussion</a>:
</p>
<div style="">
<p dir="auto">Yes, I saw that, but had no idea how to proceed. Thank you for helping me unblock this.</p>
<blockquote dir="auto">
<p>Is the error case you have in mind to test supposed to trigger an alert or not?</p>
</blockquote>
<p dir="auto">No, (if my assumptions are correct) it should test for <code>GNUTLS_E_PUSH_ERROR</code>. The original test already tests that (see psk-file.c, <a href="https://gitlab.com/gnutls/gnutls/blob/master/tests/psk-file.c#L413">line 413</a>):</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">/* try without server credentials */</span>
<span id="LC2" class="line" lang="plaintext">run_test3("NORMAL:-VERS-ALL:+VERS-TLS1.3:+PSK:+DHE-PSK", NULL, "jas", &key, 1, 0, 0, GNUTLS_E_PUSH_ERROR, GNUTLS_E_INSUFFICIENT_CREDENTIALS);</span></code></pre>
<p dir="auto">The new test just extends that failure case to binary users, as I assume behavior should be the same regardless of whether the user is binary or not:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">/* try without server credentials */</span>
<span id="LC2" class="line" lang="plaintext">run_test3("NORMAL:-VERS-ALL:+VERS-TLS1.3:+PSK:+DHE-PSK", NULL, &user_jas, &key, 1, 0, 0, GNUTLS_E_PUSH_ERROR, GNUTLS_E_INSUFFICIENT_CREDENTIALS, 0);</span>
<span id="LC3" class="line" lang="plaintext">run_test3("NORMAL:-VERS-ALL:+VERS-TLS1.3:+PSK:+DHE-PSK", NULL, &user_hex, &key, 1, 0, 0, GNUTLS_E_PUSH_ERROR, GNUTLS_E_INSUFFICIENT_CREDENTIALS, 1);</span>
<span id="LC4" class="line" lang="plaintext">run_test3("NORMAL:-VERS-ALL:+VERS-TLS1.3:+PSK:+DHE-PSK", NULL, &user_null_1, &key, 1, 0, 0, GNUTLS_E_PUSH_ERROR, GNUTLS_E_INSUFFICIENT_CREDENTIALS, 1);</span>
<span id="LC5" class="line" lang="plaintext">run_test3("NORMAL:-VERS-ALL:+VERS-TLS1.3:+PSK:+DHE-PSK", NULL, &user_null_2, &key, 1, 0, 0, GNUTLS_E_PUSH_ERROR, GNUTLS_E_INSUFFICIENT_CREDENTIALS, 1);</span></code></pre>
<p dir="auto">Any idea how should we proceed?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/917#note_227571269">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/1523f9f60f2197b1dbaacfa0e578fe01/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/917#note_227571269"}}</script>
</p>
</div>
</body>
</html>