<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/rockdaboot">Tim Rühsen</a> created an issue:
</p>
<div></div>
<p dir="auto">Shouldn't it be <code>if (tdata.data == NULL || tdata.size > req_size) {</code> ?</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">/* returns data from a string in a constant buffer. Will</span>
<span id="LC2" class="line" lang="plaintext"> * fail with GNUTLS_E_PARSING_ERROR, if the string has not enough data.</span>
<span id="LC3" class="line" lang="plaintext"> */</span>
<span id="LC4" class="line" lang="plaintext">int</span>
<span id="LC5" class="line" lang="plaintext">_gnutls_buffer_pop_data(gnutls_buffer_st * str, void *data,</span>
<span id="LC6" class="line" lang="plaintext"> size_t req_size)</span>
<span id="LC7" class="line" lang="plaintext">{</span>
<span id="LC8" class="line" lang="plaintext"> gnutls_datum_t tdata;</span>
<span id="LC9" class="line" lang="plaintext"></span>
<span id="LC10" class="line" lang="plaintext"> _gnutls_buffer_pop_datum(str, &tdata, req_size);</span>
<span id="LC11" class="line" lang="plaintext"> fprintf(stderr,"%zu %zu\n", tdata.size, req_size);</span>
<span id="LC12" class="line" lang="plaintext"> if (tdata.data == NULL || tdata.size != req_size) {</span>
<span id="LC13" class="line" lang="plaintext"> return GNUTLS_E_PARSING_ERROR;</span>
<span id="LC14" class="line" lang="plaintext"> }</span>
<span id="LC15" class="line" lang="plaintext"></span>
<span id="LC16" class="line" lang="plaintext"> memcpy(data, tdata.data, tdata.size);</span>
<span id="LC17" class="line" lang="plaintext"></span>
<span id="LC18" class="line" lang="plaintext"> return 0;</span>
<span id="LC19" class="line" lang="plaintext">}</span></code></pre>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/844">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/8635c2fa1ffd49599cce147ccb316aac/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/844"}}</script>
</p>
</div>
</body>
</html>