<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/nmav">Nikos Mavrogiannopoulos</a>
commented:
</p>
<div style="">
<p dir="auto">Would you like to clarify the commit message to something more expressive e.g., "reject certificates accepts whose notbefore field is a non-digits", and mention the bug number int he description, e.g., "Resolves <a href="https://gitlab.com/gnutls/gnutls/issues/840" data-original="#840" data-link="false" data-link-reference="false" data-project="179611" data-issue="25398669" data-reference-type="issue" data-container="body" data-placement="bottom" title="certtool --generate-privkey leaks private key by default" class="gfm gfm-issue has-tooltip">#840</a>". Also would you like to add the reproducer as part of the test suite e.g, in <code>tests/cert-tests/certtool</code> or even separately, so that we ensure we do not regress in the future?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1134#note_261661788">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/6f58a0aeb63b5dbebea156de5acf90ba/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1134#note_261661788"}}</script>
</p>
</div>
</body>
</html>