<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/rockdaboot">Tim Rühsen</a>
commented on a
discussion on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1139#note_263549758">Makefile.am</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="101" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
101
</td>
<td class="diff-line-num new_line" data-linenumber="101" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
101
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC101" class="line" lang="make"></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="102" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
102
</td>
<td class="diff-line-num new_line" data-linenumber="102" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
102
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC102" class="line" lang="make"><span class="nl">abi-check-latest</span><span class="o" style="font-weight: 600;">:</span> <span class="nf" style="color: #900; font-weight: 600;">lib/libgnutls.la libdane/libgnutls-dane.la</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="103" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
103
</td>
<td class="diff-line-num new_line" data-linenumber="103" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
103
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC103" class="line" lang="make"> <span class="p">@</span><span class="nb" style="color: #0086b3;">echo</span> <span class="s2" style="color: #d14;">"Checking whether the latest ABI dump matches"</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="104" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
104
</td>
<td class="diff-line-num new_line old" data-linenumber="104" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC104" class="line" lang="make"> <span class="p">@</span>abidiff <span class="nt" style="color: #000080;">--suppressions</span> <span class="nv" style="color: #008080;">$(ABIGNORE_FILE)</span> lib/.libs/libgnutls.so <span class="nv" style="color: #008080;">$(LIBGNUTLS_ABI_LAST_FILE)</span> <span class="nt" style="color: #000080;">--hd2</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: #008080;">$(srcdir)</span><span class="s2" style="color: #d14;">/lib/includes/gnutls/"</span><span class="p">;</span> <span class="k" style="font-weight: 600;">if </span><span class="nb" style="color: #0086b3;">test</span> <span class="nv" style="color: #008080;">$$</span>? <span class="o" style="font-weight: 600;">!=</span> 0<span class="p">;</span><span class="k" style="font-weight: 600;">then</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="105" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="104" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
104
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC104" class="line" lang="make"> <span class="p">@</span>abidiff <span class="nt" style="color: #000080;">--suppressions</span> <span class="nv" style="color: #008080;">$(ABIGNORE_FILE)</span> lib/.libs/libgnutls.so <span class="nv" style="color: #008080;">$(LIBGNUTLS_ABI_LAST_FILE)</span> <span class="nt" style="color: #000080;">--hd2</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: #008080;">$(srcdir)</span><span class="s2" style="color: #d14;">/lib/includes/gnutls/"</span><span class="idiff left"> </span><span class="nt" style="color: #000080;"><span class="idiff">--hd2</span></span><span class="idiff right"> lib/includes/gnutls/ </span><span class="p">;</span> <span class="k" style="font-weight: 600;">if </span><span class="nb" style="color: #0086b3;">test</span> <span class="nv" style="color: #008080;">$$</span>? <span class="o" style="font-weight: 600;">!=</span> 0<span class="p">;</span><span class="k" style="font-weight: 600;">then</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
</table>
<div style="">
<p dir="auto">My bad, you are right regarding <code>top_builddir</code> and <code>builddir</code>.</p>
<p dir="auto">So do you think we can remove all occurrences of <code>$(builddir)/</code> in <code>Makefile.am</code> ?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1139#note_263549758">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/3a3143d921fdd6c15107b202271c6820/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1139#note_263549758"}}</script>
</p>
</div>
</body>
</html>