<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/airtower-luna">Airtower</a> created a merge request:
</p>
<p>
</p>
<div class="branch">
Project:Branches: airtower-luna/gnutls:wip-save-ocsp-multi to gnutls/gnutls:master
</div>
<div class="author">
Author: Airtower
</div>
<div class="assignee">
Assignees:
</div>
<div class="approvers">
</div>
<div>
<p dir="auto">This is the second part of a fix for <a href="https://gitlab.com/gnutls/gnutls/issues/904" data-original="#904" data-link="false" data-link-reference="false" data-project="179611" data-issue="29511561" data-reference-type="issue" data-container="body" data-placement="bottom" title="gnutls-cli logs only the first stapled OCSP response" class="gfm gfm-issue has-tooltip">#904</a>. I consider the feature itself complete, but there's no test yet, and I'd like some feedback on the patch, in particular:</p>
<ul dir="auto">
<li>
<p>Is the change to <code>--save-ocsp</code> acceptable (always create the file, even if empty)? It makes using the same code for both <code>--save-ocsp</code> and the new <code> --save-ocsp-multi</code> a simpler.</p>
</li>
<li>
<p><a href="https://gitlab.com/nmav" data-user="105950" data-reference-type="user" data-container="body" data-placement="bottom" class="gfm gfm-project_member" title="Nikos Mavrogiannopoulos">@nmav</a>, you suggested marking <code>--save-ocsp</code> as deprecated. The <a href="https://www.gnu.org/software/autogen/manual/html_section/Option-Definitions.html#Common-Attributes" rel="nofollow noreferrer noopener" target="_blank">Autogen documentation</a> indicates that the <code>deprecated</code> flag is deprecated though, what's the preferred approach here?</p>
</li>
<li>
<p>Is there any test already testing <code>gnutls-cli</code> with OCSP stapling that I could base a test on?</p>
</li>
</ul>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Commits have <code>Signed-off-by:</code> with name/author being identical to the commit author</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1189">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/28f7af780e0966a10076291f46146296/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1189"}}</script>
</p>
</div>
</body>
</html>