<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<p style="color: #777777;">

<a href="https://gitlab.com/rockdaboot">Tim Rühsen</a>

commented:

</p>

<div style="">

<p dir="auto">I think it would be good to have error messages in case something goes wrong. Staying silent may lead to wrong assumptions and hard to find issues later. Check all calls to fwrite/fclose and also print an error message when gnutls_ocsp_status_request_get2() fails.</p>

<p dir="auto">Then why use PEM for SAVE_OCSP_MULTI and DER for SAVE_OCSP ? IMO it would be more consistent when both options use the same output format. What about checking the file extension (.pem | .der) and/or have another option to specify the output format ?</p>

<p dir="auto">Else LGTM :-)</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1189#note_283814898">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/1dbe191d6de58e02ab3800c618876f99/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1189#note_283814898"}}</script>

</p>

</div>

</body>

</html>