<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/artemisty">Artemis Tosini</a> created an issue:
</p>
<div></div>
<h2 dir="auto">
<a id="user-content-description-of-problem" class="anchor" href="#description-of-problem" aria-hidden="true"></a>Description of problem:</h2>
<p dir="auto">The certtool test in cert-tests does not detect any password and fails at <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/tests/cert-tests/certtool#L59">line 59</a> since it relies on getpass falling back to stdin and stderr if it is unable to connect to a TTY. This only occurs on glibc (<a href="https://sourceware.org/git/?p=glibc.git;a=blob;f=misc/getpass.c;h=1a9379e116ba5afb568f606ffff7b358d5d387c3;hb=HEAD#l58" rel="nofollow noreferrer noopener" target="_blank">source code</a>), while other libcs like musl (<a href="https://git.musl-libc.org/cgit/musl/tree/src/legacy/getpass.c#n15" rel="nofollow noreferrer noopener" target="_blank">source code</a>) do not have this behaviour.</p>
<p dir="auto">I can think of a few options to fix this</p>
<ul dir="auto">
<li>Change <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/src/common.c#L1026">getpass_copy</a> to directly use utility functions in <code>termios.h</code>. This would be most compatible with existing scripts. Note that according to <a href="https://linux.die.net/man/3/getpass" rel="nofollow noreferrer noopener" target="_blank">its man page</a>, getpass is obsolete.</li>
<li>Stop relying on this behavior and test functionality another way, such as giving another password and making sure certtool fails.</li>
<li>Try to make a pty so that the existing test line still works. This should be possible, but I have no idea how to do it.</li>
</ul>
<h2 dir="auto">
<a id="user-content-version-of-gnutls-used" class="anchor" href="#version-of-gnutls-used" aria-hidden="true"></a>Version of gnutls used:</h2>
<p dir="auto">3.6.12</p>
<h2 dir="auto">
<a id="user-content-distributor-of-gnutls-eg-ubuntu-fedora-rhel" class="anchor" href="#distributor-of-gnutls-eg-ubuntu-fedora-rhel" aria-hidden="true"></a>Distributor of gnutls (e.g., Ubuntu, Fedora, RHEL)</h2>
<p dir="auto">NixOS</p>
<h2 dir="auto">
<a id="user-content-how-reproducible" class="anchor" href="#how-reproducible" aria-hidden="true"></a>How reproducible:</h2>
<p dir="auto">Steps to Reproduce:</p>
<ul dir="auto">
<li>Build gnutls with musl libc (in my case <code>nix-build '<nixpkgs>' -A pkgsMusl.gnutls</code>)</li>
<li>Run tests</li>
</ul>
<h2 dir="auto">
<a id="user-content-actual-results" class="anchor" href="#actual-results" aria-hidden="true"></a>Actual results:</h2>
<p dir="auto">The test fails with the following log:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">Generating a 3072 bit RSA private key...</span>
<span id="LC2" class="line" lang="plaintext">Generating a self signed certificate...</span>
<span id="LC3" class="line" lang="plaintext">No PIN given.</span>
<span id="LC4" class="line" lang="plaintext">note: when operating in batch mode, set the GNUTLS_PIN or GNUTLS_SO_PIN environment variables</span>
<span id="LC5" class="line" lang="plaintext">cert generation failed</span>
<span id="LC6" class="line" lang="plaintext">FAIL certtool (exit status: 1)</span></code></pre>
<h2 dir="auto">
<a id="user-content-expected-results" class="anchor" href="#expected-results" aria-hidden="true"></a>Expected results:</h2>
<p dir="auto">The test should pass</p>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/945">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/3c048c5fdb5d1b954db62f635edbc60f/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/945"}}</script>
</p>
</div>
</body>
</html>