<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/jjelen">Jakub Jelen</a> created a merge request:
</p>
<p>
</p>
<div class="branch">
Project:Branches: jjelen/gnutls:eddsa-pkcs11 to gnutls/gnutls:master
</div>
<div class="author">
Author: Jakub Jelen
</div>
<div class="assignee">
Assignees:
</div>
<div class="approvers">
</div>
<div>
<p dir="auto">Fixes <a href="https://gitlab.com/gnutls/gnutls/issues/946" data-original="#946" data-link="false" data-link-reference="false" data-project="179611" data-issue="31390364" data-reference-type="issue" data-container="body" data-placement="top" data-html="true" title="Unable to use Ed25519 keys from PKCS#11" class="gfm gfm-issue has-tooltip">#946</a></p>
<p dir="auto">I will have to look into testing this later if needed. So far tested manually in OpenSC, that I am able to load EdDSA Key into gnutls and use them to create self-signed certificate:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">Key pair generated:</span>
<span id="LC2" class="line" lang="plaintext">Private Key Object; EC_EDWARDS</span>
<span id="LC3" class="line" lang="plaintext"> label: EDDSA</span>
<span id="LC4" class="line" lang="plaintext"> ID: 05</span>
<span id="LC5" class="line" lang="plaintext"> Usage: decrypt, sign, unwrap, derive</span>
<span id="LC6" class="line" lang="plaintext"> Access: sensitive, always sensitive, never extractable, local</span>
<span id="LC7" class="line" lang="plaintext">Public Key Object; EC_EDWARDS EC_POINT 255 bits</span>
<span id="LC8" class="line" lang="plaintext"> EC_POINT: 0420aa0e50140a7f0c88f0cbcfb97a82f50814c22968f9547da18756a513b95ffbc6</span>
<span id="LC9" class="line" lang="plaintext"> EC_PARAMS: 130c656477617264733235353139</span>
<span id="LC10" class="line" lang="plaintext"> label: EDDSA</span>
<span id="LC11" class="line" lang="plaintext"> ID: 05</span>
<span id="LC12" class="line" lang="plaintext"> Usage: encrypt, verify, wrap, derive</span>
<span id="LC13" class="line" lang="plaintext"> Access: local</span>
<span id="LC14" class="line" lang="plaintext">Generating a self signed certificate...</span>
<span id="LC15" class="line" lang="plaintext">X.509 Certificate Information:</span>
<span id="LC16" class="line" lang="plaintext"> Version: 3</span>
<span id="LC17" class="line" lang="plaintext"> Serial Number (hex): 52200fa099f0b6dc47e0ac7edebedb27f3e9f871</span>
<span id="LC18" class="line" lang="plaintext"> Validity:</span>
<span id="LC19" class="line" lang="plaintext"> Not Before: Fri Feb 28 15:16:17 UTC 2020</span>
<span id="LC20" class="line" lang="plaintext"> Not After: Sat Feb 27 15:16:17 UTC 2021</span>
<span id="LC21" class="line" lang="plaintext"> Subject: O=OpenSC</span>
<span id="LC22" class="line" lang="plaintext"> Subject Public Key Algorithm: EdDSA (Ed25519)</span>
<span id="LC23" class="line" lang="plaintext"> Algorithm Security Level: High (256 bits)</span>
<span id="LC24" class="line" lang="plaintext"> Curve: Ed25519</span>
<span id="LC25" class="line" lang="plaintext"> X:</span>
<span id="LC26" class="line" lang="plaintext"> aa:0e:50:14:0a:7f:0c:88:f0:cb:cf:b9:7a:82:f5:08</span>
<span id="LC27" class="line" lang="plaintext"> 14:c2:29:68:f9:54:7d:a1:87:56:a5:13:b9:5f:fb:c6</span>
<span id="LC28" class="line" lang="plaintext"> Extensions:</span>
<span id="LC29" class="line" lang="plaintext"> Basic Constraints (critical):</span>
<span id="LC30" class="line" lang="plaintext"> Certificate Authority (CA): FALSE</span>
<span id="LC31" class="line" lang="plaintext"> Subject Alternative Name (not critical):</span>
<span id="LC32" class="line" lang="plaintext"> RFC822Name: none@example.org</span>
<span id="LC33" class="line" lang="plaintext"> Key Usage (critical):</span>
<span id="LC34" class="line" lang="plaintext"> Digital signature.</span>
<span id="LC35" class="line" lang="plaintext"> Subject Key Identifier (not critical):</span>
<span id="LC36" class="line" lang="plaintext"> 09322de3f242ea5066c96ae46c1b27104ac453be</span>
<span id="LC37" class="line" lang="plaintext">Other Information:</span>
<span id="LC38" class="line" lang="plaintext"> Public Key ID:</span>
<span id="LC39" class="line" lang="plaintext"> sha1:09322de3f242ea5066c96ae46c1b27104ac453be</span>
<span id="LC40" class="line" lang="plaintext"> sha256:60bfb7e740ca4cd3ca05fae5a6bdc2a6be51d635e998e9a8bf9f31ea70356f1a</span>
<span id="LC41" class="line" lang="plaintext"> Public Key PIN:</span>
<span id="LC42" class="line" lang="plaintext"> pin-sha256:YL+350DKTNPKBfrlpr3Cpr5R1jXpmOmov58x6nA1bxo=</span>
<span id="LC43" class="line" lang="plaintext"></span>
<span id="LC44" class="line" lang="plaintext"></span>
<span id="LC45" class="line" lang="plaintext"></span>
<span id="LC46" class="line" lang="plaintext">Signing certificate...</span>
<span id="LC47" class="line" lang="plaintext">Using slot 0 with a present token (0x1b840330)</span>
<span id="LC48" class="line" lang="plaintext">Created certificate:</span>
<span id="LC49" class="line" lang="plaintext">Certificate Object; type = X.509 cert</span>
<span id="LC50" class="line" lang="plaintext"> label: EDDSA</span>
<span id="LC51" class="line" lang="plaintext"> subject: DN: O=OpenSC</span>
<span id="LC52" class="line" lang="plaintext"> ID: 05</span></code></pre>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Commits have <code>Signed-off-by:</code> with name/author being identical to the commit author</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1200">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/c62019afbadfe76ac0979aa942182c9e/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1200"}}</script>
</p>
</div>
</body>
</html>