<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a> created an issue:
</p>
<div></div>
<p dir="auto">When adding a new API function, one biggest pain point is updating <code>lib{gnutls,dane}-latest-x86_64.abi</code> files, because the output of <code>abidw</code> is not stable and information that relies on the current build environment is emitted, e.g., <code>comp-dir-path='/home/nmav/cvs/gnutls-mine/lib'</code>.</p>
<p dir="auto">Interestingly, <code>abidiff</code> only takes into account of the existence of <code>elf-symbol</code> (ignores type changes). So one can cheat <code>abi-check</code> by manually adding an <code>elf-symbol</code> entry for the new function: <a href="https://gitlab.com/gnutls/gnutls/-/commit/623058337490b847d27b736c67b6e710efb980a7" data-original="example 2" data-link="true" data-link-reference="false" data-project="179611" data-commit="623058337490b847d27b736c67b6e710efb980a7" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="crypto-api: add generic crypto functions for KDF" class="gfm gfm-commit has-tooltip">example 2</a>, <a href="https://gitlab.com/gnutls/gnutls/-/commit/6037706541616cfd2d4b49f6f5939ce6dddd1a53" data-original="example 1" data-link="true" data-link-reference="false" data-project="179611" data-commit="6037706541616cfd2d4b49f6f5939ce6dddd1a53" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="crypto-api: add gnutls_hmac_get_key_size() function" class="gfm gfm-commit has-tooltip">example 1</a>. That means, there is not much sense to maintain <code>lib{gnutls,dane}-latest-x86_64.abi</code>, as we already have <code>devel/symbols.last</code>.</p>
<p dir="auto">Therefore I propose:</p>
<ul dir="auto">
<li>drop <code>lib{gnutls,dane}-latest-x86_64.abi</code> and check against it (keep <code>lib{gnutls,dane}-$(VERSION)-x86_64.abi</code>
</li>
<li>maintain the output of <code>abidiff</code> from the previous <code>lib{gnutls,dane}-$(VERSION)-x86_64.abi</code> in the repository, say <code>lib{gnutls,dane}-x86_64.abidiff</code>
</li>
<li>add an instruction to update <code>lib{gnutls,dane}-$(VERSION)-x86_64.abi</code> and clear <code>lib{gnutls,dane}-x86_64.abidiff</code> at release time</li>
</ul>
<p dir="auto">This not only makes <code>make file-updates</code> reliable, but also tightens the check as it covers type changes.</p>
<p dir="auto">Thoughts?</p>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/954">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/dac0b8d292ed8146e44205922ee84c0a/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/954"}}</script>
</p>
</div>
</body>
</html>