<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/peterdettman">Peter Dettman</a>
commented:
</p>
<div style="">
<p dir="auto">Currently Ed448 peer certificates don't pass (TLS peer) verification. The underlying reason is that the Ed448 hash is SHAKE-256:</p>
<p dir="auto"><code>{.name = "EdDSA-Ed448", ..., .hash = GNUTLS_DIG_SHAKE_256, ...}</code></p>
<p dir="auto">but SHAKE-256 has no output_size specified:</p>
<p dir="auto"><code>{.name = "SHAKE-256", .oid = HASH_OID_SHAKE_256, .id = GNUTLS_MAC_SHAKE_256, .block_size = 136}</code></p>
<p dir="auto">so I assume output_size is defaulting to 0, which leads to (gnutls-serv 3.6.12 when Ed448 client cert presented, verification enabled):</p>
<blockquote dir="auto">
<p>|<2>| GNUTLS_SEC_PARAM_LOW: certificate's signature hash strength is unacceptable (is 0 bits, needed 80)</p>
</blockquote>
<p dir="auto">Incidentally, I also noticed that tests/sign-is-secure.c is not covering Ed448 because the loop bound is off-by-1:</p>
<p dir="auto"><code>for (i=1;i<GNUTLS_SIGN_MAX;i++)</code></p>
<p dir="auto">GNUTLS_SIGN_MAX (== GNUTLS_SIGN_EDDSA_ED448) should be included in the loop.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/128#note_304892538">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/4aeef51f886033ade42b858e43443117/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/128#note_304892538"}}</script>
</p>
</div>
</body>
</html>