<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<p style="color: #777777;">

<a href="https://gitlab.com/CendioOssman">Pierre Ossman (Work account)</a>

commented on a

<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1223#note_312015550">discussion</a>:

</p>

<div style="">

<p dir="auto">I don't know. I don't know how often such comparisons are made in normal scenarios. You'd be the expert here.</p>

<p dir="auto">I can probably synthesize a test to compare <code>_gnutls_x509_compare_raw_dn()</code> before and after, but that doesn't necessarily translate to real world numbers.</p>

<p dir="auto">As for a cache, where would we store it? We just get a <code>gnutls_datum_t</code> and not something high level.</p>

<p dir="auto">So wait and see if anyone complains?</p>

<p dir="auto">I could also reverse the logic. I.e. do a binary comparison first (most cases), and do the slow comparison as a fallback.</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1223#note_312015550">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/a471bf345dbcf4af4bdcda33ec58b10b/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1223#note_312015550"}}</script>

</p>

</div>

</body>

</html>