<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a> created a merge request:
</p>
<p>
</p>
<div class="branch">
Branches: tmp-valgrind-memcheck to master
</div>
<div class="author">
Author: Daiki Ueno
</div>
<div class="assignee">
Assignees:
</div>
<div class="approvers">
</div>
<div>
<p dir="auto">See <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1227" data-original="!1227" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="53979357" data-project-path="gnutls/gnutls" data-iid="1227" data-mr-title="Added reproducer for fix in !1225" data-reference-type="merge_request" data-container="body" data-placement="top" data-html="true" title="" class="gfm gfm-merge_request">!1227</a>.</p>
<p dir="auto">This tightens the check introduced in
<a href="https://gitlab.com/gnutls/gnutls/-/commit/ac2f71b892d13a7ab4cc39086eef179042c7e23c" data-original="ac2f71b892d13a7ab4cc39086eef179042c7e23c" data-link="false" data-link-reference="false" data-project="179611" data-commit="ac2f71b892d13a7ab4cc39086eef179042c7e23c" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="tests: added check for random value of client and server hello in TLS" class="gfm gfm-commit has-tooltip">ac2f71b8</a>, by using the valgrind client
request to explicitly mark the "uninitialized but initialization is
needed before use" regions. With this patch and the
fix (<a href="https://gitlab.com/gnutls/gnutls/-/commit/c01011c2d8533dbbbe754e49e256c109cb848d0d" data-original="c01011c2d8533dbbbe754e49e256c109cb848d0d" data-link="false" data-link-reference="false" data-project="179611" data-commit="c01011c2d8533dbbbe754e49e256c109cb848d0d" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="dtls client hello: fix zeroed random (fixes #960)" class="gfm gfm-commit has-tooltip">c01011c2</a>) reverted, you will see
the following error when running dtls_hello_random_value under
valgrind:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext"> $ valgrind ./dtls_hello_random_value</span>
<span id="LC2" class="line" lang="plaintext"> testing: default</span>
<span id="LC3" class="line" lang="plaintext"> ==520145== Conditional jump or move depends on uninitialised value(s)</span>
<span id="LC4" class="line" lang="plaintext"> ==520145== at 0x4025F5: hello_callback (dtls_hello_random_value.c:90)</span>
<span id="LC5" class="line" lang="plaintext"> ==520145== by 0x488BF97: _gnutls_call_hook_func (handshake.c:1215)</span>
<span id="LC6" class="line" lang="plaintext"> ==520145== by 0x488C1AA: _gnutls_send_handshake2 (handshake.c:1332)</span>
<span id="LC7" class="line" lang="plaintext"> ==520145== by 0x488FC7E: send_client_hello (handshake.c:2290)</span>
<span id="LC8" class="line" lang="plaintext"> ==520145== by 0x48902A1: handshake_client (handshake.c:2908)</span>
<span id="LC9" class="line" lang="plaintext"> ==520145== by 0x48902A1: gnutls_handshake (handshake.c:2740)</span>
<span id="LC10" class="line" lang="plaintext"> ==520145== by 0x402CB3: client (dtls_hello_random_value.c:153)</span>
<span id="LC11" class="line" lang="plaintext"> ==520145== by 0x402CB3: start (dtls_hello_random_value.c:317)</span>
<span id="LC12" class="line" lang="plaintext"> ==520145== by 0x402EFE: doit (dtls_hello_random_value.c:331)</span>
<span id="LC13" class="line" lang="plaintext"> ==520145== by 0x4023D4: main (utils.c:254)</span>
<span id="LC14" class="line" lang="plaintext"> ==520145==</span></code></pre>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Commits have <code>Signed-off-by:</code> with name/author being identical to the commit author</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1228">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/f7115e62ef207a8f3048f8d98c2b4188/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1228"}}</script>
</p>
</div>
</body>
</html>