<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
<a href="https://gitlab.com/gstrauss">Glenn Strauss</a> created a merge request:
</p>
<p>
</p>
<div class="branch">
Project:Branches: gstrauss/gnutls:specialize-gnutls_load_file to gnutls/gnutls:master
</div>
<div class="author">
Author: Glenn Strauss
</div>
<div class="assignee">
Assignees:
</div>
<div class="approvers">
</div>
<div>
<p dir="auto">specialize <code>gnutls_load_file()</code> for unix-like OS</p>
<p dir="auto">This implementation is safer, more secure, more robust, and more efficient than the existing generic implementation using system stdio.</p>
<p dir="auto">reference: #1002</p>
<p dir="auto"><a href="https://gitlab.com/dueno" data-user="470892" data-reference-type="user" data-container="body" data-placement="top" data-html="true" class="gfm gfm-project_member js-user-link" title="Daiki Ueno">@dueno</a> has committed some related improvements to gnulib <a href="http://git.savannah.gnu.org/gitweb/?p=gnulib.git" rel="nofollow noreferrer noopener" target="_blank">http://git.savannah.gnu.org/gitweb/?p=gnulib.git</a>
<a href="http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=e4a38aadac2e90c6dfb317d0845746c200cf6697" rel="nofollow noreferrer noopener" target="_blank">http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=e4a38aadac2e90c6dfb317d0845746c200cf6697</a>
<a href="http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=a2080f6506701d8d9ca5111d628607a6a8013f61" rel="nofollow noreferrer noopener" target="_blank">http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=a2080f6506701d8d9ca5111d628607a6a8013f61</a>
<a href="http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=fb64a78174042189f4d012cbd748d565f021cd69" rel="nofollow noreferrer noopener" target="_blank">http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=fb64a78174042189f4d012cbd748d565f021cd69</a></p>
<p dir="auto">This patch for gnutls loads a file into a gnutls_datum_t, but most of this patch could alternatively be submitted to the gnulib implementation of <code>read_file()</code>. Were that to be done, gnutls would retain the cost of double-copying the file contents in <code>gnutls_load_file()</code> when <code>gnutls_malloc != malloc</code></p>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Commits have <code>Signed-off-by:</code> with name/author being identical to the commit author</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Code modified for feature</li>
<li>[-] Test suite updated with functionality tests</li>
<li>[-] Test suite updated with negative tests</li>
<li>[-] Documentation updated / NEWS entry present (for non-trivial changes)</li>
<li>[-] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1270">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/fe4cb48174c0c1f84389b60123f341e2/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1270"}}</script>
</p>
</div>
</body>
</html>