<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/gstrauss">Glenn Strauss</a>
commented:
</p>
<div style="">
<p dir="auto">I added some commits to demonstrate more consistent easier and more correct code using the <code>gnutls_load_file()</code> interface and passing function params using the <code>gnutls_datum_t</code> data structure.</p>
<p dir="auto">With the latest push, I built gnutls and ran all tests with <code>make check</code>. All tests pass (or were skipped by the test harness)</p>
<p dir="auto">Along the way, I fixed a bug in <code>src/certtool.c:load_infile()</code> which misreported the filename in the error condition, always reporting <code>OPT_ARG(INFILE)</code> instead of the <code>file</code> param passed into <code>load_infile()</code></p>
<p dir="auto">Remaining in the gnutls codebase (after applying these patches) is a single call to <code>read_file()</code> (for non-unix systems) and a single call to <code>fread_file()</code> for the applications under <code>src/</code> when the apps read <code>stdin</code> or device files.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1270#note_352385153">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/06af4f027519f2692b90b00e2fbfb3d2/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1270#note_352385153"}}</script>
</p>
</div>
</body>
</html>