<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<p style="color: #777777;">

<a href="https://gitlab.com/smuellerDD">Stephan Mueller</a>

commented:

</p>

<div style="">

<p dir="auto">The check in itself is good and I have no comments.</p>

<p dir="auto">Yet, I am wondering about the following: the check is added to <code>_gnutls_proc_dh_common_server_kx</code>. This function seems to indicate that the call is in the TLS server. But shouldn't the call be also in the client  considering that the server sends the domain parameters to the client? That said, wouldn't the check be better found in the actual DH function like gnutls_pk_derive or similar?</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1295#note_369623014">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/-/sent_notifications/53ba7b2ddc02b748555000c9bd0f2cd0/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1295#note_369623014"}}</script>

</p>

</div>

</body>

</html>