<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/CurtisVillamizar">CurtisVillamizar</a> created an issue <a href="https://gitlab.com/gnutls/gnutls/-/issues/1078">#1078</a>:
</p>
<div></div>
<h2 dir="auto">
<a id="user-content-description-of-problem" class="anchor" href="#description-of-problem" aria-hidden="true"></a>Description of problem:</h2>
<p dir="auto">Attached is a fix/workaround to _gnutls_x509_der_encode (in lib/x509/common.c) that should not work but does. The change provides a buffer to asn1_der_coding rather than zero when only the size is needed. The suspected reason that this works is without the buffer asn1_der_coding is doing some inplace modification affecting later calls. That reason is not proven. A test case (c++ program) to reproduce the problem and shell output giving limited debug output is (or will be shortly) provided. A prior version of gnutls worked.</p>
<h2 dir="auto">
<a id="user-content-version-of-gnutls-used" class="anchor" href="#version-of-gnutls-used" aria-hidden="true"></a>Version of gnutls used:</h2>
<p dir="auto">3.6.14 (on FreeBSD 12.1-STABLE #0 r363326M)</p>
<h2 dir="auto">
<a id="user-content-distributor-of-gnutls-eg-ubuntu-fedora-rhel" class="anchor" href="#distributor-of-gnutls-eg-ubuntu-fedora-rhel" aria-hidden="true"></a>Distributor of gnutls (e.g., Ubuntu, Fedora, RHEL)</h2>
<p dir="auto">FreeBSD ports collection (revision 542586) compiled with FreeBSD clang version 10.0.0</p>
<h2 dir="auto">
<a id="user-content-how-reproducible" class="anchor" href="#how-reproducible" aria-hidden="true"></a>How reproducible:</h2>
<p dir="auto">100% of the time with provided c++ program. Fix works 100% of the time in cases where it should work.</p>
<p dir="auto">Steps to Reproduce:</p>
<ul dir="auto">
<li>one - read instructions in first few comment lines of provided test program</li>
<li>two - follow directions to compile and run testcase 0 to 5 (only 1 and 5 <em>should not</em> produce core dump)</li>
<li>three - apply patch to gnutls and relink - testcase 1 and 5 now produce success</li>
</ul>
<h2 dir="auto">
<a id="user-content-actual-results" class="anchor" href="#actual-results" aria-hidden="true"></a>Actual results:</h2>
<p dir="auto">Testcase 0-5 produce core dump without patch to gnutls. Testcase 1 and 5 succeed with patch.</p>
<h2 dir="auto">
<a id="user-content-expected-results" class="anchor" href="#expected-results" aria-hidden="true"></a>Expected results:</h2>
<p dir="auto">Testcase 1 and 5 should succeed. Other testcases exist to provide information and are OK to core dump. But it would be nice (tm) if a few didn't fail.
<a href="https://gitlab.com/gnutls/gnutls/uploads/bda48bf8693ed2ae1655a4306d0349a2/patch-common.c" data-link="true" class="gfm">patch-common.c</a></p>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1078">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/48c401fdf7d1ca359ec5918358355dec/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1078"}}</script>
</p>
</div>
</body>
</html>