<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
commented:
</p>
<div style="">
<p dir="auto">Went through the list, my thoughts:</p>
<p dir="auto">FIPS DH changes warrant a changelog entry, but are limited to FIPS-aware scenarios,
and are a future compliance issue so that's OK to backport them.</p>
<p dir="auto">Out of the rest, the following has caught my attention:</p>
<p dir="auto"><code>5ec267d2 p12: do not encrypt encrypt certificate bag with empty password</code> <br>
<code>47714178 certtool: do not ask for private key password if it was provided</code> <br>
change the certool behaviour while not bringing new possibilities to the table. <br>
Not sure what's the expected stability of certool's interface though, maybe it's fine.</p>
<p dir="auto"><code>b4bfe1a8 pubkey: avoid spurious audit messages from _gnutls_pubkey_compatible_with_sig()</code> <br>
is unlikely to break someone's setup, but still might be worth mentioning in the changelog.</p>
<p dir="auto"><code>022d36a8 cert-session: fail hard if mandatory stapling is not honored</code> <br>
<code>9b2732d4 serv, cli: ensure that invalid flag is always set</code> <br>
are definitely worth documenting.</p>
<p dir="auto"><code>29c3e00b gnutls_x509_crt_export2: return 0 instead of the length</code> <br>
should be documented.</p>
<p dir="auto"><code>dea420fa cert-session: check OCSP error responses</code> <br>
I don't like this one, guess I don't understand OCSP.
Does this make OCSP-responder validation best-effort?</p>
<p dir="auto"><code>4e2571b7 handshake: check TLS version against modified server priorities</code> <br>
should be documented</p>
<p dir="auto">The others are unlikely to pose any issue to an updating user.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1317#note_404560288">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/36c2a306a61e95f0e0b63d6965f6c526/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1317#note_404560288"}}</script>
</p>
</div>
</body>
</html>