<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/zzjianhui">zzjianhui</a> created a merge request:
</p>
<p>
</p>
<div class="branch">
Project:Branches: zzjianhui/gnutls:fix-padlock to gnutls/gnutls:master
</div>
<div class="author">
Author: zzjianhui
</div>
<div class="assignee">
Assignees:
</div>
<div class="approvers">
</div>
<div>
<p dir="auto">Add detection of extended instruction set on Zhaoxin cpu,e.g:ssse3,sha,avx,etc. Set the priority of the algorithm according to the benchmark test result on Zhaoxin cpu.</p>
<p dir="auto">In hmac-padlock.c, use free to release local variables ctx. Remove a call to wrap_padlock_hmac_deinit() to fix a crash.</p>
<p dir="auto">This is the previous test situation<a href="https://gitlab.com/gnutls/gnutls/uploads/b8f0305e2051b3eee16b0a04bf1e22c3/test-suite.log" data-link="true" class="gfm">test-suite.log</a>. This is the test situation after adding these codes<a href="https://gitlab.com/gnutls/gnutls/uploads/53ac0885f5f2dba7f0f1ac79ca887355/test-suite1.log" data-link="true" class="gfm">test-suite1.log</a>.</p>
<p dir="auto">fixes <a href="https://gitlab.com/gnutls/gnutls/-/issues/1094" data-original="#1094" data-link="false" data-link-reference="false" data-project="179611" data-issue="71279691" data-reference-type="issue" data-container="body" data-placement="top" title="x86/padlock: Use free() on local variables" class="gfm gfm-issue has-tooltip">#1094</a> ,<a href="https://gitlab.com/gnutls/gnutls/-/issues/1079" data-original="#1079" data-link="false" data-link-reference="false" data-project="179611" data-issue="70553889" data-reference-type="issue" data-container="body" data-placement="top" title="Add detection of extended instruction set on zhaoxin CPU" class="gfm gfm-issue has-tooltip">#1079</a></p>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Commits have <code>Signed-off-by:</code> with name/author being identical to the commit author</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1335">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/7b3d76e16ee4791b2330404add98d1d8/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1335"}}</script>
</p>
</div>
</body>
</html>