<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/ametzler">Andreas Metzler</a>
commented:
</p>
<div style="">
<p dir="auto">Latest version <a href="https://gitlab.com/gnutls/gnutls/-/commit/af73fac0273d1af0c6411235148b7c5b079ab75a" data-original="af73fac0273d1af0c6411235148b7c5b079ab75a" data-link="false" data-link-reference="false" data-project="179611" data-commit="af73fac0273d1af0c6411235148b7c5b079ab75a" data-reference-type="commit" data-container="body" data-placement="top" title="tests: simplify program detection" class="gfm gfm-commit has-tooltip">af73fac0</a> looks good, except for:</p>
<pre class="code highlight js-syntax-highlight shell" lang="shell" v-pre="true"><code><span id="LC1" class="line" lang="shell">ocsp-tests/ocsp-tls-connection</span>
<span id="LC2" class="line" lang="shell"><span class="o">[</span>...]</span>
<span id="LC3" class="line" lang="shell">: <span class="k">${</span><span class="nv">CLI</span><span class="p">=../src/gnutls-cli</span><span class="k">${</span><span class="nv">EXEEXT</span><span class="k">}}</span></span>
<span id="LC4" class="line" lang="shell"><span class="o">[</span>...]</span>
<span id="LC5" class="line" lang="shell"><span class="k">if</span> <span class="o">!</span> <span class="nb">test</span> <span class="nt">-x</span> <span class="s2">"</span><span class="k">${</span><span class="nv">GNUTLS_CLI</span><span class="k">}</span><span class="s2">"</span><span class="p">;</span> <span class="k">then</span></span>
<span id="LC6" class="line" lang="shell"><span class="k"> </span><span class="nb">exit </span>77</span>
<span id="LC7" class="line" lang="shell"><span class="k">fi</span></span></code></pre>
<p dir="auto">Is there a reason that we have tests using <code>: ${CERTTOOL=../src/certtool}</code> and other tests using <code>: ${CERTTOOL=../src/certtool${EXEEXT}}</code>. (not only for certtool but also for other commands, too?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1337#note_419125185">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/fbfe182254b7db5c11a4553e47770d39/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1337#note_419125185"}}</script>
</p>
</div>
</body>
</html>