<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<p style="color: #777777;">

<a href="https://gitlab.com/smuellerDD">Stephan Mueller</a>

commented:

</p>

<div style="">

<ul dir="auto">

<li>

<p>CMAC: I see no problems in having both AES key sizes tested, but one would suffice (also cryptographically).</p>

</li>

<li>

<p>TLS: Looks good</p>

</li>

<li>

<p>PBKDF2: looks good</p>

</li>

<li>

<p>HKDF: looks good - Is that code also applicable to TLS 1.3 KDF? If so, I would

recommend adding a comment to state that avoiding later questions. If not, what about considering a TLS 1.3 KDF self test?</p>

</li>

</ul>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #666;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1341#note_424197662">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/-/sent_notifications/1a3a4983ff92dd56044bb316484dc3db/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1341#note_424197662"}}</script>

</p>

</div>

</body>

</html>