<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1341#note_424396515">discussion</a>:
</p>
<div style="">
<p dir="auto"><a href="https://gitlab.com/smuellerDD" data-user="1650358" data-reference-type="user" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Stephan Mueller">@smuellerDD</a> thank you for the review!</p>
<blockquote dir="auto">
<p>CMAC: I see no problems in having both AES key sizes tested, but one would suffice (also cryptographically).</p>
</blockquote>
<p dir="auto">Removed one (AES-128).</p>
<blockquote dir="auto">
<p>HKDF: looks good - Is that code also applicable to TLS 1.3 KDF? If so, I would recommend adding a comment to state that avoiding later questions. If not, what about considering a TLS 1.3 KDF self test?</p>
</blockquote>
<p dir="auto">I'm a bit confused about this; would you mind clarifying what exactly "TLS 1.3 KDF" means (ideally in the RFC 8446 terms)?</p>
<p dir="auto">I see some <a href="https://mailarchive.ietf.org/arch/msg/tls/qANkz08Yyel84C1pzPGc2g9h3XI/" rel="nofollow noreferrer noopener" target="_blank">discussions</a> regarding SP800-56C additions of HKDF a while ago, but not sure what was the outcome.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1341#note_424396515">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/9e8f05469952d542a6438dca57733357/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1341#note_424396515"}}</script>
</p>
</div>
</body>
</html>