<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1354#note_448006960">discussion</a>:
</p>
<div style="">
<p dir="auto">Sorry, <a href="https://gitlab.com/sahprasa" data-user="1160630" data-reference-type="user" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Sahana Prasad">@sahprasa</a>. It's my fault not having thought it seriously, but I realized that the current usage of the issuer callback in the library is not very reasonable: we probably shouldn't modify the trust list during chain verification as a side effect.</p>
<p dir="auto">Therefore, I moved the chain amendment logic from <code>verify_crt</code> to <code>gnutls_x509_trust_list_verify_crt2</code> and rewritten it in a side-effect free manner. The missingissuer test should now cover all the possible patterns.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1354#note_448006960">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/ec82c6370e25b2b5237ceb882d7154e6/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1354#note_448006960"}}</script>
</p>
</div>
</body>
</html>