<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1364#note_457262256">lib/x509/x509_dn.c</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="173" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
173
</td>
<td class="diff-line-num new_line" data-linenumber="173" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
173
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC173" class="line" lang="c"></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="174" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
174
</td>
<td class="diff-line-num new_line" data-linenumber="174" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
174
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC174" class="line" lang="c"> <span class="cm" style="color: #998; font-style: italic;">/* remove spaces from the end */</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="175" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
175
</td>
<td class="diff-line-num new_line" data-linenumber="175" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
175
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC175" class="line" lang="c"> <span class="k" style="font-weight: 600;">while</span><span class="p">(</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">size</span> <span class="o" style="font-weight: 600;">></span> <span class="mi" style="color: #099;">0</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">c_isspace</span><span class="p">(</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">data</span><span class="p">[</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">size</span><span class="o" style="font-weight: 600;">-</span><span class="mi" style="color: #099;">1</span><span class="p">]))</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="176" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
176
</td>
<td class="diff-line-num new_line old" data-linenumber="176" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC176" class="line" lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">size</span><span class="o" style="font-weight: 600;"><span class="idiff left">-</span></span><span class="mi" style="color: #099;"><span class="idiff">2</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">></span></span><span class="idiff"> </span><span class="mi" style="color: #099;"><span class="idiff right">0</span></span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">data</span><span class="p">[</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">size</span><span class="o" style="font-weight: 600;">-</span><span class="mi" style="color: #099;">2</span><span class="p">]</span> <span class="o" style="font-weight: 600;">==</span> <span class="sc" style="color: #d14;">'\\'</span><span class="p">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="177" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="176" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
176
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC176" class="line" lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">size</span><span class="idiff left"> </span><span class="o" style="font-weight: 600;"><span class="idiff">></span></span><span class="idiff"> </span><span class="mi" style="color: #099;"><span class="idiff right">2</span></span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">data</span><span class="p">[</span><span class="n" style="color: #333;">val</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">size</span><span class="o" style="font-weight: 600;">-</span><span class="mi" style="color: #099;">2</span><span class="p">]</span> <span class="o" style="font-weight: 600;">==</span> <span class="sc" style="color: #d14;">'\\'</span><span class="p">)</span></span>
</pre>
</td>
</tr>
</table>
<div style="">
<p dir="auto">Not your fault, but I wonder if this logic works when the '\' appears at the beginning of the data (i.e., shouldn't <code>val->size > 2</code> be <code>val->size > 1</code>?).</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1364#note_457262256">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/86f30f048f80f142ffc057c80b6f9f8d/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1364#note_457262256"}}</script>
</p>
</div>
</body>
</html>