<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a> created an issue <a href="https://gitlab.com/gnutls/gnutls/-/issues/1174">#1174</a>:
</p>
<div></div>
<p dir="auto">As we are adopting valgrind instruments more and <a href="https://gitlab.com/gnutls/gnutls/-/commit/3d7fae761e65e9d0f16d7247ee8a464d4fe002da" data-original="more" data-link="true" data-link-reference="false" data-project="179611" data-commit="3d7fae761e65e9d0f16d7247ee8a464d4fe002da" data-reference-type="commit" data-container="body" data-placement="top" title="valgrind: check if session ticket key is used without initialization" class="gfm gfm-commit has-tooltip">more</a>, it would make sense to run all the tests under valgrind in CI. However, for some reason it's disabled when <code>--disable-full-test-suite</code> is specified and that's the case with the "fedora-valgrind/build" job. I tried to enable it but found quite a few roadblocks:</p>
<ul dir="auto">
<li>the gnulib <code>valgrind-tests</code> module usage is incorrect and the current code exercises also for shell-scripts (i.e. bash binary) - we should properly set <code>TEST_EXTENSIONS = .sh</code>
</li>
<li>there are actual memleaks in some code e.g., <code>tests/tls13/no-auto-send-ticket.c</code>
</li>
<li>the FIPS library state check is done too late (I don't know why), and the tests manually invalidating the state (e.g., <code>tests/x509sign-verify-error.c</code>) causes memory error deep under nettle primitives, because the gnutls random functions refuses to produce proper value in that case, resulting in the dest memory area uninitialized</li>
<li>some tests (e.g., <code>tests/memset.c</code>) are poorly written, violating the C ABI assumption (those are removed in <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1382" data-original="!1382" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="85888026" data-project-path="gnutls/gnutls" data-iid="1382" data-mr-title="safe-memfuncs: rely on explicit_bzero implementation from gnulib" data-reference-type="merge_request" data-container="body" data-placement="top" title="" class="gfm gfm-merge_request">!1382</a>)</li>
</ul>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1174">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/bd47281080853073e1d8b8c18a584fd5/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1174"}}</script>
</p>
</div>
</body>
</html>