<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/stweil">Stefan Weil</a>
commented on a
discussion on <a href="https://gitlab.com/gnutls/libtasn1/-/merge_requests/71#note_500619189">lib/coding.c</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="old_line diff-line-num" data-linenumber="1204" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1204
</td>
<td class="new_line diff-line-num" data-linenumber="1205" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1205
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1205" class="line" lang="c"> <span class="k" style="font-weight: 600;">goto</span> <span class="n" style="color: #333;">error</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="old_line diff-line-num" data-linenumber="1205" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1205
</td>
<td class="new_line diff-line-num" data-linenumber="1206" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1206
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1206" class="line" lang="c"> <span class="p">}</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="old_line diff-line-num" data-linenumber="1206" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1206
</td>
<td class="new_line diff-line-num" data-linenumber="1207" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1207
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1207" class="line" lang="c"> <span class="n" style="color: #333;">len2</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333;">max_len</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="old_line diff-line-num old" data-linenumber="1207" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
1207
</td>
<td class="new_line diff-line-num old" data-linenumber="1208" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC1207" class="line" lang="c"> <span class="n" style="color: #333;">err</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333;">_asn1_object_id_der</span> <span class="p">((</span><span class="kt" style="color: #458; font-weight: 600;">char</span><span class="o" style="font-weight: 600;">*</span><span class="p">)</span><span class="n" style="color: #333;">p</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">value</span><span class="p">,</span> <span class="n" style="color: #333;">der</span> <span class="o" style="font-weight: 600;"><span class="idiff left">+</span></span><span class="idiff"> </span><span class="n" style="color: #333;"><span class="idiff right">counter</span></span><span class="p">,</span> <span class="o" style="font-weight: 600;">&</span><span class="n" style="color: #333;">len2</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="old_line diff-line-num new" data-linenumber="1208" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="1208" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1208
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1208" class="line" lang="c"> <span class="n" style="color: #333;">err</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333;">_asn1_object_id_der</span> <span class="p">((</span><span class="kt" style="color: #458; font-weight: 600;">char</span><span class="o" style="font-weight: 600;">*</span><span class="p">)</span><span class="n" style="color: #333;">p</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">value</span><span class="p">,</span> <span class="n" style="color: #333;">der</span> <span class="o" style="font-weight: 600;"><span class="idiff left">?</span></span><span class="idiff"> </span><span class="n" style="color: #333;"><span class="idiff">der</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">+</span></span><span class="idiff"> </span><span class="n" style="color: #333;"><span class="idiff">counter</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">:</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">&</span></span><span class="n" style="color: #333;"><span class="idiff right">dummy</span></span><span class="p">,</span> <span class="o" style="font-weight: 600;">&</span><span class="n" style="color: #333;">len2</span><span class="p">);</span></span>
</pre>
</td>
</tr>
</table>
<div style="">
<p dir="auto">That would work, too, but requires more changes in those functions.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/libtasn1/-/merge_requests/71#note_500619189">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/db6d08ca8364c6e051823ebb40dcb72e/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/libtasn1/-/merge_requests/71#note_500619189"}}</script>
</p>
</div>
</body>
</html>