<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/ametzler">Andreas Metzler</a> created an issue <a href="https://gitlab.com/gnutls/gnutls/-/issues/1181">#1181</a>:
</p>
<div></div>
<p dir="auto">After <a href="https://gitlab.com/gnutls/gnutls/-/commit/37e54a05221e076ba905d2d53fc7d885dc9e9ebc" data-original="37e54a05221e076ba905d2d53fc7d885dc9e9ebc" data-link="false" data-link-reference="false" data-project="179611" data-commit="37e54a05221e076ba905d2d53fc7d885dc9e9ebc" data-reference-type="commit" data-container="body" data-placement="top" title="tests: close unused fd opened by socketpair" class="gfm gfm-commit has-tooltip">37e54a05</a> resume-with-stek-expiration throws a fishy warning but exits with success.</p>
<p dir="auto">Patching 3.7.0 release with
<a href="https://gitlab.com/gnutls/gnutls/-/commit/e0bb98e1f71f94691f600839ff748d3a9f469d3e" data-original="e0bb98e1f71f94691f600839ff748d3a9f469d3e" data-link="false" data-link-reference="false" data-project="179611" data-commit="e0bb98e1f71f94691f600839ff748d3a9f469d3e" data-reference-type="commit" data-container="body" data-placement="top" title="Fix non-empty session id (TLS13_APPENDIX_D4)" class="gfm gfm-commit has-tooltip">e0bb98e1</a>
<a href="https://gitlab.com/gnutls/gnutls/-/commit/09b40be6e0e0a59ba4bd764067eb353241043a70" data-original="09b40be6e0e0a59ba4bd764067eb353241043a70" data-link="false" data-link-reference="false" data-project="179611" data-commit="09b40be6e0e0a59ba4bd764067eb353241043a70" data-reference-type="commit" data-container="body" data-placement="top" title="gnutls_x509_trust_list_verify_crt2: ignore duplicate certificates" class="gfm gfm-commit has-tooltip">09b40be6</a>
<a href="https://gitlab.com/gnutls/gnutls/-/commit/05ee0d49fe93d8812ef220c7b830c4b3553ac4fd" data-original="05ee0d49fe93d8812ef220c7b830c4b3553ac4fd" data-link="false" data-link-reference="false" data-project="179611" data-commit="05ee0d49fe93d8812ef220c7b830c4b3553ac4fd" data-reference-type="commit" data-container="body" data-placement="top" title="handshake: TLS 1.3: don't generate session ID in resumption mode" class="gfm gfm-commit has-tooltip">05ee0d49</a>
<a href="https://gitlab.com/gnutls/gnutls/-/commit/37e54a05221e076ba905d2d53fc7d885dc9e9ebc" data-original="37e54a05221e076ba905d2d53fc7d885dc9e9ebc" data-link="false" data-link-reference="false" data-project="179611" data-commit="37e54a05221e076ba905d2d53fc7d885dc9e9ebc" data-reference-type="commit" data-container="body" data-placement="top" title="tests: close unused fd opened by socketpair" class="gfm gfm-commit has-tooltip">37e54a05</a>
results in something that seems to break resume-with-stek-expiration without triggering an actual error:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">(sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.7.0/tests$ ./resume-with-stek-expiration --verbose ; echo $?</span>
<span id="LC2" class="line" lang="plaintext"></span>
<span id="LC3" class="line" lang="plaintext">[...]</span>
<span id="LC4" class="line" lang="plaintext">testing tls1.3 resumption</span>
<span id="LC5" class="line" lang="plaintext"></span>
<span id="LC6" class="line" lang="plaintext">STEK was rotated!</span>
<span id="LC7" class="line" lang="plaintext">client: Handshake was completed</span>
<span id="LC8" class="line" lang="plaintext">server: Handshake was completed</span>
<span id="LC9" class="line" lang="plaintext">client: Success: Session was NOT resumed</span>
<span id="LC10" class="line" lang="plaintext">server: Success: Session was NOT resumed</span>
<span id="LC11" class="line" lang="plaintext">STEK was rotated!</span>
<span id="LC12" class="line" lang="plaintext">client: Handshake was completed</span>
<span id="LC13" class="line" lang="plaintext">client: Success: Session was resumed</span>
<span id="LC14" class="line" lang="plaintext">server: Handshake was completed</span>
<span id="LC15" class="line" lang="plaintext">server: Success: Session was resumed</span>
<span id="LC16" class="line" lang="plaintext">STEK was rotated!</span>
<span id="LC17" class="line" lang="plaintext">server: Handshake was completed</span>
<span id="LC18" class="line" lang="plaintext">server: Success: Session was resumed</span>
<span id="LC19" class="line" lang="plaintext">client: Handshake was completed</span>
<span id="LC20" class="line" lang="plaintext">client: Success: Session was resumed</span>
<span id="LC21" class="line" lang="plaintext">STEK was rotated!</span>
<span id="LC22" class="line" lang="plaintext">client: Handshake was completed</span>
<span id="LC23" class="line" lang="plaintext">server: Handshake was completed</span>
<span id="LC24" class="line" lang="plaintext">server: Success: Session was NOT resumed</span>
<span id="LC25" class="line" lang="plaintext">resume_and_close:134: client: Session was resumed (but should not)</span>
<span id="LC26" class="line" lang="plaintext">Self test `./resume-with-stek-expiration' finished with 0 errors</span>
<span id="LC27" class="line" lang="plaintext">0</span></code></pre>
<p dir="auto">Not the "resume_and_close:134: client: Session was resumed (but should not)".</p>
<p dir="auto">(I accidentally stumbled over this while cherrypicking, Git HEAD (<a href="https://gitlab.com/gnutls/gnutls/-/commit/2ea09dff25c74a4da598efdc62e7d3b42a11727c" data-original="2ea09dff25c74a4da598efdc62e7d3b42a11727c" data-link="false" data-link-reference="false" data-project="179611" data-commit="2ea09dff25c74a4da598efdc62e7d3b42a11727c" data-reference-type="commit" data-container="body" data-placement="top" title=".gitlab-ci.yml: remove FreeBSD run" class="gfm gfm-commit has-tooltip">2ea09dff</a>) does not show the message.</p>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1181">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/90513e4fa43c634ab22505d2a4aa5b1c/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1181"}}</script>
</p>
</div>
</body>
</html>