<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1383#note_519494090">commented</a>:
</p>
<div style="">
<p dir="auto">Hi, sorry for the late review.</p>
<p dir="auto">Looks mostly fine to me, I have just two questions:</p>
<ol dir="auto">
<li>
<p>I don't understand the reason for dropping tests/init_fds.c in <a href="https://gitlab.com/gnutls/gnutls/-/commit/5589765593b8af88e4fc3acb3b06ded0122da006" data-original="5589765" data-link="false" data-link-reference="false" data-project="179611" data-commit="5589765593b8af88e4fc3acb3b06ded0122da006" data-reference-type="commit" data-container="body" data-placement="top" title="tests: remove init_fds test" class="gfm gfm-commit has-tooltip">55897655</a>.
My impression is, it'd be still useful to test that an application
can close all fds in between implicit and explicit init.
I don't see why the test is irrelevant to
"only open /dev/urandom when gnutls_global_init() is called and not before"
of <a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760476" rel="nofollow noreferrer noopener" target="_blank">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760476</a>
I'd appreciate some clarification here.</p>
</li>
<li>
<p>What's the policy of what to call and not call under valgrind
in shell script tests? I've picked one test at random
(<code>tests/cert-tests/certtool.sh</code>) and I see a mixture of calls to certtool,
some do call valgrind, some don't.</p>
</li>
</ol>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1383#note_519494090">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/e8b27c062a6ce5049240b7e8f4205f44/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1383#note_519494090"}}</script>
</p>
</div>
</body>
</html>