<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1383#note_521658462">discussion</a>:
</p>
<div style="">
<blockquote dir="auto">
<p>I don't see why the test is irrelevant to "only open /dev/urandom when gnutls_global_init() is called and not before" of <a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760476" rel="nofollow noreferrer noopener" target="_blank">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760476</a> I'd appreciate some clarification here.</p>
</blockquote>
<p dir="auto">I generally agree with you, though the test didn't properly exercise the scenario on some cases, because it assumes that /dev/urandom is always associated with fd 3. I guess one way to reliably do that check would be to (1) replace gnutls_rnd as other tests do and (2) in that replacement function, call stat and compare the inode number against a newly opened /dev/urandom.</p>
<blockquote dir="auto">
<p>What's the policy of what to call and not call under valgrind in shell script tests? I've picked one test at random (tests/cert-tests/certtool.sh) and I see a mixture of calls to certtool, some do call valgrind, some don't.</p>
</blockquote>
<p dir="auto">That sounds like a bug ;-)</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1383#note_521658462">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/74b0819e1fe8967236165e62b07e0cc9/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1383#note_521658462"}}</script>
</p>
</div>
</body>
</html>