<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/nielsmoller">Niels Möller</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1407#note_544529364">commented</a>:
</p>
<div style="">
<p dir="auto">I don't have the full context. Regarding <a href="https://git.lysator.liu.se/nettle/nettle/-/commit/5b7608fde3a6d2ab82bffb35db1e4e330927c906" rel="nofollow noreferrer noopener" target="_blank">https://git.lysator.liu.se/nettle/nettle/-/commit/5b7608fde3a6d2ab82bffb35db1e4e330927c906</a>, that is indeed a cleanup. The bug fix changes are those that replace ecc_mod_mul, without any additional reduction logic, with calls to ecc_mod_mul_canonical.</p>
<p dir="auto">I don't see see the fix to ecc_ecdsa_verify backported in this mr (<a href="https://git.lysator.liu.se/nettle/nettle/-/commit/2397757b3f95fcae1e2d3011bf99ca5b5438378f" rel="nofollow noreferrer noopener" target="_blank">https://git.lysator.liu.se/nettle/nettle/-/commit/2397757b3f95fcae1e2d3011bf99ca5b5438378f</a>), that seems quite important?</p>
<p dir="auto">For backports, I know that the GNU guix project is interested in a backport to nettle-3.5, see <a href="https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47222" rel="nofollow noreferrer noopener" target="_blank">https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47222</a></p>
<p dir="auto">I might make sense to add a helper similar to the the ecc_mod_mul_canonical in nettl-3.7.2, but as you have noticed, it can't be identical due to the changed conventions for ecc_mod_mul and the underlying mod functions. But I think it should be fairly straight forward to write a variant with an interface compatible with ecc_mod_mul in older versions.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1407#note_544529364">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/1e0078e1ee3df88e58682c7f12f39928/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1407#note_544529364"}}</script>
</p>
</div>
</body>
</html>