<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/dkg">Daniel Kahn Gillmor</a> created an issue: <a href="https://gitlab.com/gnutls/gnutls/-/issues/1263">#1263</a>
</p>
<div></div>
<p dir="auto">in <code>src/certtool.c</code>, in <code>generate_pkcs12(common_info_st * cinfo)</code>, we see:</p>
<pre class="code highlight js-syntax-highlight language-plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext"> if (i == 0) { /* only the first certificate gets the friendly name */</span></code></pre>
<p dir="auto">But all the included private keys get the friendlyName attribute. (all keys and non-CA certs get the localKeyID attribute)</p>
<p dir="auto">Some PKCS#12 importers might try to match certs with private keys by matching friendlyName <em>and</em> localKeyID attributes. If one of the certs is missing the friendlyName and it has a corresponding private key, those importers might fail to find it.</p>
<p dir="auto">Granted, those importers could match just on the localKeyID attribute, but in that case there's no reason for the friendlyName attribute at all. If <code>certtool</code> is going to emit the <code>friendlyName</code> at all, it should:</p>
<ul dir="auto">
<li>if there are no private keys, apply the friendlyName only to the first certificate (as it currently does)</li>
<li>if there are private keys, it should apply the friendlyName to any certificate whose SPKI matches the public key corresponding to one of the private keys.</li>
</ul>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1263">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/cf6efa93f418b4af7af6dd28669a9361/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1263"}}</script>
</p>
</div>
</body>
</html>