<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1467#note_669980027">commented</a>:
</p>
<div style="">
<p dir="auto">re <a href="https://gitlab.com/gnutls/gnutls/-/commit/f23c3a6cba43706a6ebb3f9b0018cd658dcc0a72" data-original="f23c3a6cba43706a6ebb3f9b0018cd658dcc0a72" data-link="false" data-link-reference="false" data-project="179611" data-commit="f23c3a6cba43706a6ebb3f9b0018cd658dcc0a72" data-reference-type="commit" data-container="body" data-placement="top" title="mem: instrument with ASan memory poisoning as well as valgrind" class="gfm gfm-commit has-tooltip">f23c3a6c</a>: good to have it!</p>
<p dir="auto">re this MR: not particularly convinced on the time saving side.</p>
<p dir="auto">Quoting select competing stage 3 job durations from the <a href="https://gitlab.com/gnutls/gnutls/-/pipelines/363372618/builds">latest pipeline of master at the time of writing</a>:</p>
<pre class="code highlight js-syntax-highlight language-plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">passed debian-cross/aarch64-linux-gnu/test 00:53:03</span>
<span id="LC2" class="line" lang="plaintext">passed debian-cross/arm-linux-gnueabihf/test 00:50:56</span>
<span id="LC3" class="line" lang="plaintext">failed fedora-notools/test 03:00:02</span>
<span id="LC4" class="line" lang="plaintext">passed fedora-static-analyzers/test 01:40:34</span>
<span id="LC5" class="line" lang="plaintext">passed fedora-valgrind-aggressive/test 00:29:23</span>
<span id="LC6" class="line" lang="plaintext">passed fedora-valgrind/test 00:28:36</span></code></pre>
<p dir="auto">Doesn't look like valgrind jobs are on the critical path. If timeouts are caused by hanging tests and not raw performance considerations, I'd prefer test fixing and both checkks coexisting.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1467#note_669980027">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/2d7874b2630941f9759d200cf504a136/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1467#note_669980027"}}</script>
</p>
</div>
</body>
</html>