<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/rwmjones">Richard W.M. Jones</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_680381199">commented</a>:
</p>
<div style="">
<p dir="auto">From the point of view of a potential user of the API, it would be best to have a way to allow ktls to be used, but not fail if it cannot be used (it is, after all, an optimization). And if we have that, then why do we need a <code>set_ktls</code> option at all? Just make it happen if it's possible, otherwise fall back to software.</p>
<p dir="auto">Another way to think about this: If you add the <code>set_ktls</code> API, then why <strong>wouldn't</strong> everyone use it all the time?</p>
<p dir="auto">However it would be nice to have a <code>get_ktls</code> function which tells us if kTLS is being used. We could report that in debugging output in libnbd for example (<a href="https://gitlab.com/nbdkit/libnbd/-/blob/72ad5b2ab41e5253901a6e1c8309350a58602462/lib/crypto.c#L699">https://gitlab.com/nbdkit/libnbd/-/blob/72ad5b2ab41e5253901a6e1c8309350a58602462/lib/crypto.c#L699</a>)</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_680381199">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/7ab6693009641fc38e0cb74c3b8a4791/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_680381199"}}</script>
</p>
</div>
</body>
</html>