<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/robUx4">Steve Lhomme</a> created a merge request: <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1476">!1476</a>
</p>
<p>
</p>
<div class="branch">
Project:Branches: robUx4/gnutls:mingw64-detection to gnutls/gnutls:master
</div>
<div class="author">
Author: Steve Lhomme
</div>
<div class="assignee">
Assignees:
</div>
<div class="reviewer">
Reviewers:
</div>
<div class="approvers">
</div>
<div>
<p dir="auto">When building for mingw64 i686, <code>CertEnumCRLsInStore</code> is used via LoadLibrary, even though it's available in the toolchain.</p>
<p dir="auto">The <code>#ifdef</code> in the original code was intended to only do it for old versions of <code>mingw32</code> and never for <code>mingw64</code>. But the check for <code>__MINGW64__</code> is incorrect as it only matches 64-bits versions of <code>mingw64</code>.</p>
<p dir="auto">This patch uses <code>__MINGW64_VERSION_MAJOR</code> instead of <code>__MINGW64__</code>.</p>
<p dir="auto">This was not a problem so far as <code>LoadLibrary</code> is available on regular Windows builds. But it's not available in UWP builds, system calls have to be linked directly, not called indirectly via <code>LoadLibrary</code>.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1476">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/0ec242a7dd7a466e6c39b31b9e503ae8/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1476"}}</script>
</p>
</div>
</body>
</html>