<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1482#note_718509521">commented</a>:
</p>
<div style="">
<p dir="auto">LGTM.</p>
<p dir="auto">As you have <a href="https://bugzilla.redhat.com/show_bug.cgi?id=2012249#c12" rel="nofollow noreferrer noopener" target="_blank">rightfully noted</a>, there's also write access to <code>system_wide_priority_strings</code> in <code>_gnutls_unload_system_priorities()</code>, but this is only called from <code>_gnutls_global_deinit()</code>, which isn't supposed to be thread-safe.</p>
<p dir="auto">One thing that caught my attention while reviewing this: we also don't clear <code>system_wide_priority_strings_init</code> there (or anywhere). That doesn't sound right if one deinits and then reinits, is that a valid scenario?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1482#note_718509521">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/d3ba4c326f0a0599bfc2eac7e407a862/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1482#note_718509521"}}</script>
</p>
</div>
</body>
</html>