<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1465#note_736633369">commented</a>:
</p>
<div style="">
<p dir="auto"><a href="https://gitlab.com/smuellerDD" data-user="1650358" data-reference-type="user" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Stephan Mueller">@smuellerDD</a> this is the service indicator implementation we discussed some time ago. I'm currently adding the state transitions everywhere, but stumbled on where and when to trigger the indication.
Someone told me it would be reasonable to add it right after validating the arguments, but I'm a bit skeptical about that.</p>
<p dir="auto">Suppose we have a FFDH calculation; when an approved parameter is chosen, we know that the library is going to perform the actual calculation, though it will also validates Z (as in <a href="https://gitlab.com/gnutls/gnutls/-/commit/bea53f1b46a64d6dcf5bbe4794740c4d4459f9bf" data-original="bea53f1b46a64d6dcf5bbe4794740c4d4459f9bf" data-link="false" data-link-reference="false" data-project="179611" data-commit="bea53f1b46a64d6dcf5bbe4794740c4d4459f9bf" data-reference-type="commit" data-container="body" data-placement="top" title="dh: check validity of Z before export" class="gfm gfm-commit has-tooltip">bea53f1b</a>) after that. If it fails (though unlikely), should we mark the state as if there was no crypto operation performed? The DH function nevertheless return an error in that case.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1465#note_736633369">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/8cc20e4645b253c091495ac1bb96012c/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1465#note_736633369"}}</script>
</p>
</div>
</body>
</html>