<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1493#note_763824715">discussion</a>:
</p>
<div style="">
<p dir="auto">It was considered; see the description of this MR and the linked comment to Gnulib's maint.mk, which I'm expanding it for handy:</p>
<pre class="code highlight js-syntax-highlight language-make" lang="make" v-pre="true"><code><span id="LC1" class="line" lang="make"><span class="c"># Even if you use pathmax.h to guarantee that PATH_MAX is defined, it might</span></span>
<span id="LC2" class="line" lang="make"><span class="c"># not be constant, or might overflow a stack. In general, use PATH_MAX as</span></span>
<span id="LC3" class="line" lang="make"><span class="c"># a limit, not an array or alloca size.</span></span>
<span id="LC4" class="line" lang="make"><span class="nl">sc_prohibit_path_max_allocation</span><span class="o">:</span></span>
<span id="LC5" class="line" lang="make"> <span class="p">@</span><span class="nv">prohibit</span><span class="o">=</span><span class="s1">'(\balloca *\([^)]*|\[[^]]*)\bPATH_MAX'</span> <span class="se">\</span></span>
<span id="LC6" class="line" lang="make"> <span class="nv">halt</span><span class="o">=</span><span class="s1">'Avoid stack allocations of size PATH_MAX'</span> <span class="se">\</span></span>
<span id="LC7" class="line" lang="make"> <span class="nv">$(_sc_search_regexp)</span></span></code></pre>
<p dir="auto">So if we go that way, you will get the error at <code>make syntax-check</code>.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1493#note_763824715">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/66168b82124217c3276f428881e7d137/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1493#note_763824715"}}</script>
</p>
</div>
</body>
</html>