<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1499#note_791467931">discussion</a>:
</p>
<div style="">
<p dir="auto">I've added a test that compares the <code>--p12-info</code> with the expected output.</p>
<blockquote dir="auto">
<p>First: just to double check, the addition of --with-pkcs12-iter-count=10000 in test scripts is just there to speed up CI?</p>
</blockquote>
<p dir="auto">Yes, the number is based on <a href="https://searchfox.org/mozilla-central/source/security/nss/lib/pkcs7/p7create.c#21" rel="nofollow noreferrer noopener" target="_blank">https://searchfox.org/mozilla-central/source/security/nss/lib/pkcs7/p7create.c#21</a></p>
<blockquote dir="auto">
<p>Second, shouldn't we verify that 600000 is indeed the new default?</p>
</blockquote>
<p dir="auto">I think it's now covered by the new test.</p>
<blockquote dir="auto">
<p>Third, what's the HMAC used for PBKDF2? Doesn't GnuTLS default to SHA1 there?</p>
</blockquote>
<p dir="auto">Good point; I've updated it to SHA256.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1499#note_791467931">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/9f5d041e243836f2a936a6176aa5c2e1/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1499#note_791467931"}}</script>
</p>
</div>
</body>
</html>