<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1465#note_796799143">commented</a>:
</p>
<div style="">
<p dir="auto"><a href="https://gitlab.com/smuellerDD" data-user="1650358" data-reference-type="user" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Stephan Mueller">@smuellerDD</a> thank you for the review. So far, I've made the following changes based on the suggestions from <a href="https://gitlab.com/pmgdeb" data-user="2910557" data-reference-type="user" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Pedro Monreal">@pmgdeb</a>:</p>
<ul dir="auto">
<li>DH now checks if the prime is 2048-bit (otherwise mark the op as non-approved), ECDH now additionally checks P-192</li>
<li>RSA and RSA-PSS now have explicit check on the key length in KeyGen, SigGen, and SigVer</li>
<li>RSA and RSA-PSS now have explicit check on the hash algorithm in KeyGen, SigGen, and SigVer (SHA-2 only for KeyGen and SigGen, SHA-1 is also marked as approved for SigVer)</li>
<li>DSA is marked as non-approved for all uses</li>
<li>ECDSA now additionally checks P-192</li>
<li>GCM is marked as non-approved for all uses including TLS</li>
<li>HKDF is marked as non-approved for all uses including TLS</li>
</ul>
<p dir="auto">For the last two we plan to mark the TLS uses as approved, but I think it covers most of the certification requirements now.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1465#note_796799143">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/3a62f860d7a018cae4f83c0f5dfbc281/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1465#note_796799143"}}</script>
</p>
</div>
</body>
</html>