<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809593403">commented</a>:
</p>
<div style="">
<p dir="auto">Great work, hope you've enjoyed doing it. Can't say my review was very thorough, but I did what I could within the time I had at hand.</p>
<p dir="auto">In addition to the comments above, here are two commits I've jotted down while reviewing, feel free to incorporate or ignore them in full or in part, no attribution needed:</p>
<p dir="auto"><a href="https://gitlab.com/asosedkin/gnutls/-/commit/d3e6f0f3d763acf439ffc4a983b33d41a662c993" data-original="https://gitlab.com/asosedkin/gnutls/-/commit/d3e6f0f3d763acf439ffc4a983b33d41a662c993" data-link="false" data-link-reference="true" data-project="19721118" data-commit="d3e6f0f3d763acf439ffc4a983b33d41a662c993" data-reference-type="commit" data-container="body" data-placement="top" title="fixup! src: generate option handling code from JSON" class="gfm gfm-commit has-tooltip">asosedkin/gnutls@d3e6f0f3</a>
<a href="https://gitlab.com/asosedkin/gnutls/-/commit/99afb2284f9fd8e37b3aa746a4e3e2544d336e20" data-original="https://gitlab.com/asosedkin/gnutls/-/commit/99afb2284f9fd8e37b3aa746a4e3e2544d336e20" data-link="false" data-link-reference="true" data-project="19721118" data-commit="99afb2284f9fd8e37b3aa746a4e3e2544d336e20" data-reference-type="commit" data-container="body" data-placement="top" title="tests: use more aliases in tests for better alias testing coverage" class="gfm gfm-commit has-tooltip">asosedkin/gnutls@99afb228</a></p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809593403">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/9d95871e67492b4c0f3a2f79a6c03b93/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_809593403"}}</script>
</p>
</div>
</body>
</html>