<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1512#note_838165199">commented</a>:
</p>
<div style="">
<p dir="auto">Looks great in general; I've tried to connect to facebook.com with the following change:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-diff" lang="diff" v-pre="true" style="border-radius: 2px; margin: 0 0 8px; padding: 8px 12px; border: 1px solid #dbdbdb;"><code><span id="LC1" class="line" lang="diff"><span class="gh">diff --git a/src/cli.c b/src/cli.c</span></span>
<span id="LC2" class="line" lang="diff"><span class="gh">index 5378b72256..66bc67eb9f 100644</span></span>
<span id="LC3" class="line" lang="diff"><span class="gd">--- a/src/cli.c</span></span>
<span id="LC4" class="line" lang="diff"><span class="gi">+++ b/src/cli.c</span></span>
<span id="LC5" class="line" lang="diff"><span class="p">@@ -723,6 +723,8 @@</span> gnutls_session_t init_tls_session(const char *host)</span>
<span id="LC6" class="line" lang="diff"> int ret;</span>
<span id="LC7" class="line" lang="diff"> unsigned i;</span>
<span id="LC8" class="line" lang="diff"> gnutls_session_t session;</span>
<span id="LC9" class="line" lang="diff"><span class="gi">+ gnutls_compression_method_t algs[] = { GNUTLS_COMP_ZLIB };</span></span>
<span id="LC10" class="line" lang="diff"><span class="gi">+ gnutls_datum_t methods = { (unsigned char *)algs, 1 };</span></span>
<span id="LC11" class="line" lang="diff"> </span>
<span id="LC12" class="line" lang="diff"> if (udp) {</span>
<span id="LC13" class="line" lang="diff"> gnutls_init(&session, GNUTLS_DATAGRAM | init_flags);</span>
<span id="LC14" class="line" lang="diff"><span class="p">@@ -731,6 +733,12 @@</span> gnutls_session_t init_tls_session(const char *host)</span>
<span id="LC15" class="line" lang="diff"> } else</span>
<span id="LC16" class="line" lang="diff"> gnutls_init(&session, init_flags);</span>
<span id="LC17" class="line" lang="diff"> </span>
<span id="LC18" class="line" lang="diff"><span class="gi">+ ret = gnutls_compress_certificate_set_methods(session, &methods);</span></span>
<span id="LC19" class="line" lang="diff"><span class="gi">+ if (ret < 0) {</span></span>
<span id="LC20" class="line" lang="diff"><span class="gi">+ fprintf(stderr, "Could not set certificate compression methods: %s\n", gnutls_strerror(ret));</span></span>
<span id="LC21" class="line" lang="diff"><span class="gi">+ exit(1);</span></span>
<span id="LC22" class="line" lang="diff"><span class="gi">+ }</span></span>
<span id="LC23" class="line" lang="diff"><span class="gi">+</span></span>
<span id="LC24" class="line" lang="diff"> if (priorities == NULL) {</span>
<span id="LC25" class="line" lang="diff"> ret = gnutls_set_default_priority(session);</span>
<span id="LC26" class="line" lang="diff"> if (ret < 0) {</span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto">Perhaps it might be useful to have an option, say <code>--compress-cert=METHODS</code>, for <code>gnutls-cli</code> and <code>gnutls-serv</code> for interop testing?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1512#note_838165199">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/21459a18528af9d21dca1da78253d75e/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1512#note_838165199"}}</script>
</p>
</div>
</body>
</html>