<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/trapperhoney">Craig</a>
<a href="https://gitlab.com/gnutls/gnutls/-/issues/1321#note_838791050">commented</a>:
</p>
<div style="">
<p dir="auto">The simplest fix would be to simply translate GNUTLS_E_PKCS11_PIN_ERROR into GNUTLS_E_DECRYPTION_FAILED where my patch calls _gnutls_retrieve_pin. Though, it would be unfortunate to mask that error in the case one of the pin callbacks actually returns that error.</p>
<p dir="auto">A better fix would be to only call _gnutls_retrieve_pin if a pin callback is actually registered. I don't see a clean way of doing that without duplicating the callback existence checks that exist in _gnutls_retrieve_pin...</p>
<p dir="auto">Yet another option would be to modify _gnutls_retrieve_pin to take another argument representing the error code it should return when no callbacks are registered...</p>
<p dir="auto">Thoughts?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1321#note_838791050">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/3f8df80dd64481226e4bd536222970c3/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1321#note_838791050"}}</script>
</p>
</div>
</body>
</html>