<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0; margin: 0 auto;">
<tbody>
<tr>
<td style="font-family: 'Helvetica Neue',Helvetica,Arial,sans-serif; overflow: hidden;" align="left" bgcolor="#ffffff">
<table border="0" cellpadding="0" cellspacing="0" style="width: 100%; border-collapse: separate; border-spacing: 0;">
<tbody>
<tr>
<td style="color: #333333; border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid; font-size: 15px; font-weight: bold; line-height: 1.4; padding: 20px 0;">
Merge request <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535">!1535</a> was reviewed by <a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
</td>
</tr>
<tr>
<td style="overflow: hidden; font-size: 14px; line-height: 1.4; display: grid;">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535#note_863432696">src/certtool-options.json</a>:
</p>
<table>
<tr class="line_holder new">
<td class="old_line diff-line-num new" data-linenumber="26" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="26" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
26
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0"><pre style="margin: 0;">+<span id="LC26" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"short-option"</span><span class="p">:</span><span class="w" style="color: #bbb;"> </span><span class="s2" style="color: #d14;">"V"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder">
<td class="old_line diff-line-num" data-linenumber="26" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
26
</td>
<td class="new_line diff-line-num" data-linenumber="27" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
27
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;"><pre style="margin: 0;"> <span id="LC27" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"desc"</span><span class="p">:</span><span class="w" style="color: #bbb;"> </span><span class="s2" style="color: #d14;">"More verbose output"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder old">
<td class="old_line diff-line-num old" data-linenumber="27" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
27
</td>
<td class="new_line diff-line-num old" data-linenumber="28" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb"><pre style="margin: 0;">-<span id="LC27" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"disabled"</span><span class="p">:</span><span class="w" style="color: #bbb;"> </span><span class="s2" style="color: #d14;">""</span><span class="p">,</span></span>
</pre></td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">Since we no longer have <code>"disabled"</code>, we can get rid of its handling as well.</p>
</div>
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535#note_863432700">src/certtool-options.json</a>:
</p>
<table>
<tr class="line_holder">
<td class="old_line diff-line-num" data-linenumber="34" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
34
</td>
<td class="new_line diff-line-num" data-linenumber="32" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
32
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;"><pre style="margin: 0;"> <span id="LC32" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"desc"</span><span class="p">:</span><span class="w" style="color: #bbb;"> </span><span class="s2" style="color: #d14;">"Input file"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder old">
<td class="old_line diff-line-num old" data-linenumber="35" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
35
</td>
<td class="new_line diff-line-num old" data-linenumber="33" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb"><pre style="margin: 0;">-<span id="LC35" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"file-exists"</span><span class="p">:</span><span class="w" style="color: #bbb;"> </span><span class="s2" style="color: #d14;">"yes"</span></span>
</pre></td>
</tr>
<tr class="line_holder new">
<td class="old_line diff-line-num new" data-linenumber="36" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="33" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
33
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0"><pre style="margin: 0;">+<span id="LC33" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"detail"</span><span class="p">:</span><span class="w" style="color: #bbb;"> </span><span class="s2" style="color: #d14;">""</span><span class="p">,</span></span>
</pre></td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">Nit: could it be just omitted?</p>
</div>
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535#note_863432703">src/certtool-options.json</a>:
</p>
<table>
<tr class="line_holder old">
<td class="old_line diff-line-num old" data-linenumber="5" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
5
</td>
<td class="new_line diff-line-num old" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb"><pre style="margin: 0;">-<span id="LC5" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"<span class="idiff left deletion">prog-name"</span></span><span class="p"><span class="idiff deletion">:</span></span><span class="w" style="color: #bbb;"><span class="idiff deletion"> </span></span><span class="s2" style="color: #d14;"><span class="idiff right deletion">"certtool</span>"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder new">
<td class="old_line diff-line-num new" data-linenumber="6" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
4
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0"><pre style="margin: 0;">+<span id="LC4" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"<span class="idiff left addition">short-usage"</span></span><span class="p"><span class="idiff addition">:</span></span><span class="w" style="color: #bbb;"><span class="idiff addition"> </span></span><span class="s2" style="color: #d14;"><span class="idiff addition">"certtool [options]</span></span><span class="se" style="color: #d14;"><span class="idiff addition">\n</span></span><span class="s2" style="color: #d14;"><span class="idiff addition">certtool --help for usage instructions.</span></span><span class="se" style="color: #d14;"><span class="idiff right addition">\n</span></span><span class="s2" style="color: #d14;">"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder new">
<td class="old_line diff-line-num new" data-linenumber="6" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="5" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
5
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0"><pre style="margin: 0;">+<span id="LC5" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"<span class="idiff left addition">explain"</span></span><span class="p"><span class="idiff addition">:</span></span><span class="w" style="color: #bbb;"><span class="idiff addition"> </span></span><span class="s2" style="color: #d14;"><span class="idiff right addition">"</span>"</span><span class="p">,</span></span>
</pre></td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">Doesn't seem to be handled anywhere, is it OK?</p>
</div>
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535#note_863432707">src/certtool-options.json</a>:
</p>
<table>
<tr class="line_holder old">
<td class="old_line diff-line-num old" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
4
</td>
<td class="new_line diff-line-num old" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb"><pre style="margin: 0;">-<span id="LC4" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"<span class="idiff left deletion">desc"</span></span><span class="p"><span class="idiff deletion">:</span></span><span class="w" style="color: #bbb;"><span class="idiff deletion"> </span></span><span class="s2" style="color: #d14;"><span class="idiff right deletion">"</span>"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder old">
<td class="old_line diff-line-num old" data-linenumber="5" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
5
</td>
<td class="new_line diff-line-num old" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb"><pre style="margin: 0;">-<span id="LC5" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"<span class="idiff left deletion">prog-name"</span></span><span class="p"><span class="idiff deletion">:</span></span><span class="w" style="color: #bbb;"><span class="idiff deletion"> </span></span><span class="s2" style="color: #d14;"><span class="idiff right deletion">"certtool</span>"</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder new">
<td class="old_line diff-line-num new" data-linenumber="6" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="4" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
4
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0"><pre style="margin: 0;">+<span id="LC4" class="line" lang="json"><span class="w" style="color: #bbb;"> </span><span class="nl">"<span class="idiff left addition">short-usage"</span></span><span class="p"><span class="idiff addition">:</span></span><span class="w" style="color: #bbb;"><span class="idiff addition"> </span></span><span class="s2" style="color: #d14;"><span class="idiff addition">"certtool [options]</span></span><span class="se" style="color: #d14;"><span class="idiff addition">\n</span></span><span class="s2" style="color: #d14;"><span class="idiff addition">certtool --help for usage instructions.</span></span><span class="se" style="color: #d14;"><span class="idiff right addition">\n</span></span><span class="s2" style="color: #d14;">"</span><span class="p">,</span></span>
</pre></td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">diff is rather noisy, wonder why</p>
</div>
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
started a new
discussion on <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535#note_863432710">doc/scripts/gen-cmd-texi.py</a>:
</p>
<table>
<tr class="line_holder">
<td class="old_line diff-line-num" data-linenumber="46" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
46
</td>
<td class="new_line diff-line-num" data-linenumber="46" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
46
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;"><pre style="margin: 0;"> <span id="LC46" class="line" lang="python"> <span class="n" style="color: #333;">level</span><span class="p">:</span> <span class="nb" style="color: #0086b3;">int</span><span class="p">,</span></span>
</pre></td>
</tr>
<tr class="line_holder old">
<td class="old_line diff-line-num old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
47
</td>
<td class="new_line diff-line-num old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb"><pre style="margin: 0;">-<span id="LC47" class="line" lang="python"> <span class="n" style="color: #333;">options</span><span class="p">:</span> <span class="n" style="color: #333;">Sequence</span><span class="p">[</span><span class="n" style="color: #333;">Mapping</span><span class="p">[</span><span class="nb" style="color: #0086b3;">str</span><span class="p">,</span> <span class="nb" style="color: #0086b3;"><span class="idiff left right deletion">str</span></span><span class="p">]])</span> <span class="o" style="font-weight: 600;">-></span> <span class="nb" style="color: #0086b3;">str</span><span class="p">:</span></span>
</pre></td>
</tr>
<tr class="line_holder new">
<td class="old_line diff-line-num new" data-linenumber="48" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="new_line diff-line-num new" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
47
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0"><pre style="margin: 0;">+<span id="LC47" class="line" lang="python"> <span class="n" style="color: #333;">options</span><span class="p">:</span> <span class="n" style="color: #333;">Sequence</span><span class="p">[</span><span class="n" style="color: #333;">Mapping</span><span class="p">[</span><span class="nb" style="color: #0086b3;">str</span><span class="p">,</span> <span class="n" style="color: #333;"><span class="idiff left right addition">Any</span></span><span class="p">]])</span> <span class="o" style="font-weight: 600;">-></span> <span class="nb" style="color: #0086b3;">str</span><span class="p">:</span></span>
</pre></td>
</tr>
</table>
<div style="border-bottom-width: 1px; border-bottom-color: #ededed; border-bottom-style: solid;">
<p dir="auto">Not sure if it'd be reasonable to ask for a <code>TypedDict</code> schema on everything, but could it be at least a <code>Mapping[str, Value]</code>, where <code>Value</code> is <code>Union[str, ValueRange]</code> and <code>ValueRange</code> is a <code>TypedDict</code>?</p>
</div>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1535">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/6029add55c3e4502e64723aa5542afeb/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1535"}}</script>
</p>
</div>
</body>
</html>